Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some trait implementation under the test module #182

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

poljar
Copy link
Collaborator

@poljar poljar commented Sep 18, 2024

They were only implemented if the test cfg flag was enabled and used in the test module so it makes more sense that they are in the test module as well.

They were only implemented if the test cfg flag was enabled and used in
the test module so it makes more sense that they are in the test module
as well.
@poljar poljar requested a review from dkasak as a code owner September 18, 2024 13:54
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.35%. Comparing base (57cbf7e) to head (daa468b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #182   +/-   ##
=======================================
  Coverage   90.35%   90.35%           
=======================================
  Files          34       34           
  Lines        1907     1907           
=======================================
  Hits         1723     1723           
  Misses        184      184           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poljar poljar merged commit ace5a3f into main Sep 19, 2024
33 checks passed
@poljar poljar deleted the poljar/move-libolm-test-under-test branch September 19, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants