-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(french): Modified a few sentences that weren't idiomatic #153
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hope these comments help understand the translation
@@ -17,22 +17,22 @@ | |||
<h1>Ne demande pas la permission de demander, demande juste.</h1> | |||
<p> | |||
De temps en temps, dans des channels que je fréquente, | |||
je vois quelqu'un apparaître et demander, | |||
quelqu'un arrive et dit : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"someone pops in" was literally translated to "I see someone appearing". "to pop in" is an english-specific idiom.
I replaced it with a shorter, more straightforward translation : "quelqu'un arrive" which would translate literally to "someone arrives [in the channel]"
</p> | ||
<blockquote> | ||
<span class="name">Foobar123 :</span> | ||
<p class="message"> | ||
Aucun expert Java dans le coin ? | ||
Y a-t-il un expert Java dans le coin ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Any Java experts around" was translated with the sentence that made me do the PR "Aucun expert Java dans le coin?"
This isn't correct grammatically because you're supposed to start such questions with the verb in the interrogative form.
I proposed the translation "Y a-t-il un expert Java dans le coin ?", which, even if it contains a weird combination of letters and hyphens simply translates to "Is there [any] Java expert around".
In English you can omit the verb starting the sentence and making it implicit, thus giving the phrase "[is there] Any Java expert around?"
Furthermore, "Aucun" in the original translation translates to "None" "No", in the sense of a "lack of [something]. Implicitely a french speaker reading it could misunderstand and think the speaker is surprised that there are no Java experts around and asks about it rhetorically.
I believe my translation makes the text less ambiguous and more natural
@@ -83,9 +83,9 @@ <h1>Ne demande pas la permission de demander, demande juste.</h1> | |||
</p> | |||
</main> | |||
<footer> | |||
Contenu en majeure partie prise sur <a href="https://iki.fi/sol/dontask.html">iki.fi/sol/dontask.html</a> | |||
Contenu en majeure partie pris sur <a href="https://iki.fi/sol/dontask.html">iki.fi/sol/dontask.html</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo
While reading the website I noticed some of the sentences in french weren't really idiomatic and a bit too long, so I took the liberty to rewrite them to make it easier to read for french speakers. Literal word-for-word translation is often bad practice, and some of the sentences weren't technically grammatically correct, but furthermore not very natural in french which could make the understanding harder.
I'll try to explain the changes to non-french speakers by translation word for word the new ones so you can get a feel that the original meaning is preserved. I'll do it as a comment on the diff if that's possible.