Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty bookmark subfolders should have an "(empty)" entry #1123

Closed
maxmilton opened this issue Jun 27, 2021 · 1 comment · Fixed by #1149
Closed

Empty bookmark subfolders should have an "(empty)" entry #1123

maxmilton opened this issue Jun 27, 2021 · 1 comment · Fixed by #1149
Labels
blocker bug Something isn't working
Milestone
v0.18.0

Comments

@maxmilton
Copy link
Owner

maxmilton commented Jun 27, 2021 •
edited
Loading

When a bookmark folder is empty it should be clear to the user. Chrome shows a (empty) item in the folder popup in a muted colour. We should do the same.

On the old master release branch this was already implemented but after the big refactor it now needs to be implemented again.
@maxmilton maxmilton mentioned this issue Jun 27, 2021
Closed
5 tasks
@maxmilton maxmilton added blocker bug Something isn't working labels Jun 27, 2021
@maxmilton maxmilton added this to the v0.17.0 milestone Jun 27, 2021
@maxmilton maxmilton mentioned this issue Jul 11, 2021
Merged
@maxmilton
Copy link
Owner Author

Fixed in #1149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocker bug Something isn't working
Projects
None yet
Milestone
v0.18.0
Development

Successfully merging a pull request may close this issue.

Improve bookmark folder logic maxmilton/new-tab
1 participant
@maxmilton