New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve bookmark folder logic #1149

Merged

maxmilton merged 3 commits into next from feat/improve-bookmark-folder-logic

Jul 11, 2021

Owner

maxmilton commented Jul 11, 2021 •

edited

Loading

Fixes #1122
Fixes #1123

Rename "subfolder" to "folder popup"
Increase close timeout delay to 600ms
Close other popups on the same level when opening a new folder popup
Show "(empty)" in empty folder popups
Golfing to reduce output code size

maxmilton added 3 commits

July 11, 2021 11:37


          Improve bookmark folder logic

9604bd7


          Add styles

4f84b25


          Defer creating emptyPopupView until required

4e83ae8

maxmilton merged commit 29bf438 into next

maxmilton deleted the feat/improve-bookmark-folder-logic branch

July 11, 2021 01:51

maxmilton mentioned this pull request

Empty bookmark subfolders should have an "(empty)" entry #1123

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet