#735 solves wrong routes matching #740
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… working' issue (mcamara#762) Co-authored-by: Ilya Kolesnikov <ivkol@mail.ru> (cherry picked from commit c71bb11)
to handle the case of switching from arabic to another lang Co-authored-by: DJEMMAL-nour-el-islam <52753848+djemml-nour-el-islam@users.noreply.github.com> (cherry picked from commit 645819d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is a match with your code, I add a match check from laravel.
This action prevent bugs explained in #735
However, match check from laravel is a bit slow, so I added some Cache. Note that in my app, the same URL was parsing multiple time in a single request. (actually, multiple URLS multiple times in each request).
So with the cache, it is actually faster than before (in my case).
The cache TTL has been set arbitrarily to 30, but you can change it if you want.