hidden prefix redirection when locale cookie exist issue fixed #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When "hideDefaultLocaleInURL" is true and we also want to use LocaleCookieRedirect middleware there is an issue happen. If users change their language with visiting prefixed route other than default locale (ex. https://example.com/es/foo-bar) then they want to revert again to the default language with visiting default prefixed (ex. https://example.com/en/foo-bar - en is default) route, LocaleCookieRedirect middleware redirecting them to "https://example.com/es/foo-bar" because of locale cookie (it's still "es"). So I added some rows to LaravelLocalizationRedirectFilter middleware for locale cookie update.
Also I change the http status code from 302 to 301 for this redirection because of this both page exactly the same (for SEO) and add "Pragma: no-cache" header for prevent browser cache issues.