Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACAS-762-revert #1168

Open
wants to merge 1 commit into
base: release/2024.1.x
Choose a base branch
from
Open

ACAS-762-revert #1168

wants to merge 1 commit into from

Conversation

brianbolt
Copy link
Contributor

@brianbolt brianbolt commented Jun 5, 2024 •
edited
Loading

Description

Related Issue

ACAS-762

How Has This Been Tested?

TBD on merge since we don't do mule-arch builds on PRs

@brianbolt brianbolt requested a review from bffrost June 7, 2024 17:23
@bffrost
Copy link
Collaborator

bffrost commented Jun 7, 2024

@brianbolt I'm not sure that the version 18.20.1 that I put in that comment is actually the build this fix landed in. Looking through some of the links / history from the ticket, I found this commit in node where the npm version bump landed: nodejs/node@ad86a12

It says it's only in node v22

bffrost
bffrost requested changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@bffrost bffrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on my comment above, I don't think we should actually merge this right now unless there's some new information. We could update the comment to be more accurate though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bffrost bffrost bffrost requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
upmerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianbolt @bffrost