Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add SurveyInfo #94

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

berezovskyi-oleksandr
Copy link

This PR adds possibility to get the SurveyInfo for the interface

The data is the same as the output of the iw IFACE survey dump

Copy link
Collaborator

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The struct comments need to be fixed to match the data type.

wifi.go Outdated
// The noise level in dBm.
Noise int

// The time in milliseconds the radio has spent on this channel.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a time.Duration, which is actually nanoseconds. Since this is being normalized to a time.Duration, it's not actually milliseconds.

Suggested change
// The time in milliseconds the radio has spent on this channel.
// The time the radio has spent on this channel.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed milliseconds from all the comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants