Note re exception from storage.managed.get #36586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URLs
External URLs (4)URL:
URL:
(comment last updated: 2024-11-01 02:47:42) |
dotproto
requested changes
Oct 31, 2024
| @@ -28,22 +28,14 @@ Where `<storageType>` is one of the storage types — {{WebExtAPIRef("storage.sy | |||
|
|
|||
| ### Return value | |||
|
|
|||
| A [`Promise`](/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise) that resolves to a `results` object, containing every object in `keys` that was found in the storage area. If `keys` is an object, keys that are not found in the storage area will have their values given by the `keys` object. | |||
| A [`Promise`](/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise) that resolves to a `results` object, containing every object in `keys` found in the storage area. If `keys` is an object, keys that are not found in the storage area have their values given by the `keys` object. | |||
There was a problem hiding this comment.
containing every object in
keysfound in the storage area.
The wording here seems a little off. The value associated with a given may be a primitive value rather than an object. Also, the structure of this sentence seems a little harder to parse than necessary. What do you think about this?
containing a key-value pair for every matching key found in the storage area.
files/en-us/mozilla/add-ons/webextensions/api/storage/storagearea/get/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mozilla/add-ons/webextensions/api/storage/storagearea/get/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Simeon Vincent <svincent@gmail.com>
rebloor
deleted the
storage.managed.get-without-storage.managed_schema
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a note about the exception from storage.managed.get when the manage storage manifest isn't present.
Motivation
Documents a known issue with Firefox
Additional details
Originally noted as a documentation need in feedback on mdn/webextensions-examples#554