fix unit tests

medusajs · Dec 18, 2024 · bb0c432 · bb0c432
1 parent 8844b21
commit bb0c432
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 24 deletions.
diff --git a/packages/core/utils/src/dml/__tests__/entity-builder.spec.ts b/packages/core/utils/src/dml/__tests__/entity-builder.spec.ts
@@ -3019,6 +3019,7 @@ describe("Entity builder", () => {
           persist: false,
           name: "user_id",
           nullable: false,
+          formula: expect.any(Function),
           reference: "scalar",
           setter: false,
           type: "string",
@@ -3132,6 +3133,7 @@ describe("Entity builder", () => {
           type: "string",
           reference: "scalar",
           name: "email_id",
+          formula: expect.any(Function),
           nullable: false,
           persist: false,
           getter: false,
@@ -3244,6 +3246,7 @@ describe("Entity builder", () => {
           type: "string",
           reference: "scalar",
           name: "emails_id",
+          formula: expect.any(Function),
           nullable: true,
           persist: false,
           getter: false,
@@ -3347,6 +3350,7 @@ describe("Entity builder", () => {
           type: "string",
           reference: "scalar",
           name: "email_id",
+          formula: expect.any(Function),
           nullable: false,
           persist: false,
           getter: false,
@@ -3454,6 +3458,7 @@ describe("Entity builder", () => {
           type: "string",
           reference: "scalar",
           name: "email_id",
+          formula: expect.any(Function),
           nullable: false,
           persist: false,
           getter: false,
@@ -3630,6 +3635,7 @@ describe("Entity builder", () => {
           columnType: "text",
           type: "string",
           reference: "scalar",
+          formula: expect.any(Function),
           name: "email_id",
           nullable: false,
           persist: false,
@@ -3716,6 +3722,7 @@ describe("Entity builder", () => {
           name: "user_id",
           nullable: false,
           reference: "scalar",
+          formula: expect.any(Function),
           setter: false,
           type: "string",
           persist: false,
@@ -4662,6 +4669,7 @@ describe("Entity builder", () => {
           reference: "scalar",
           persist: false,
           type: "string",
+          formula: expect.any(Function),
           columnType: "text",
           nullable: false,
           name: "user_id",
@@ -4862,6 +4870,7 @@ describe("Entity builder", () => {
           type: "string",
           columnType: "text",
           nullable: true,
+          formula: expect.any(Function),
           name: "user_id",
           getter: false,
           setter: false,
@@ -5282,23 +5291,6 @@ describe("Entity builder", () => {
       })
     })
 
-    test("throw error when other side relationship is missing", () => {
-      const email = model.define("email", {
-        email: model.text(),
-        isVerified: model.boolean(),
-        user: model.belongsTo(() => user),
-      })
-
-      const user = model.define("user", {
-        id: model.number(),
-        username: model.text(),
-      })
-
-      expect(() => toMikroORMEntity(email)).toThrow(
-        'Missing property "email" on "User" entity. Make sure to define it as a relationship'
-      )
-    })
-
     test("throw error when other side relationship is invalid", () => {
       const email = model.define("email", {
         email: model.text(),
@@ -5497,6 +5489,7 @@ describe("Entity builder", () => {
           type: "string",
           persist: false,
           columnType: "text",
+          formula: expect.any(Function),
           nullable: false,
           name: "user_id",
           getter: false,
@@ -5698,6 +5691,7 @@ describe("Entity builder", () => {
           type: "string",
           columnType: "text",
           nullable: false,
+          formula: expect.any(Function),
           name: "user_id",
           getter: false,
           setter: false,
@@ -5920,6 +5914,7 @@ describe("Entity builder", () => {
           type: "string",
           columnType: "text",
           reference: "scalar",
+          formula: expect.any(Function),
           persist: false,
           getter: false,
           setter: false,

diff --git a/packages/core/utils/src/dml/helpers/entity-builder/define-relationship.ts b/packages/core/utils/src/dml/helpers/entity-builder/define-relationship.ts
@@ -487,13 +487,6 @@ export function defineBelongsToRelationship(
       relationship.options.foreignKeyName ??
       camelToSnakeCase(`${relationship.name}Id`)
 
-    Object.defineProperty(MikroORMEntity.prototype, foreignKeyName, {
-      value: null,
-      configurable: true,
-      enumerable: true,
-      writable: true,
-    })
-
     Property({
       columnType: "text",
       type: "string",