feat: Add support for managing account holder in payment module #11015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
|
sradevski
force-pushed
the
feat/add-support-manage-account-holder
branch
from
f58080f to
430878f
Compare
|
/snapshot-this |
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/admin-bundler@2.2.1-snapshot-20250117103757yarn add @medusajs/admin-sdk@2.2.1-snapshot-20250117103757yarn add @medusajs/admin-shared@2.2.1-snapshot-20250117103757yarn add @medusajs/admin-vite-plugin@2.2.1-snapshot-20250117103757yarn add @medusajs/dashboard@2.2.1-snapshot-20250117103757yarn add create-medusa-app@2.2.1-snapshot-20250117103757yarn add @medusajs/cli@2.2.1-snapshot-20250117103757yarn add medusa-dev-cli@2.2.1-snapshot-20250117103757yarn add @medusajs/medusa-oas-cli@2.2.1-snapshot-20250117103757yarn add @medusajs/core-flows@2.2.1-snapshot-20250117103757yarn add @medusajs/framework@2.2.1-snapshot-20250117103757yarn add @medusajs/js-sdk@2.2.1-snapshot-20250117103757yarn add @medusajs/modules-sdk@2.2.1-snapshot-20250117103757yarn add @medusajs/orchestration@2.2.1-snapshot-20250117103757yarn add @medusajs/types@2.2.1-snapshot-20250117103757yarn add @medusajs/utils@2.2.1-snapshot-20250117103757yarn add @medusajs/workflows-sdk@2.2.1-snapshot-20250117103757yarn add @medusajs/icons@2.2.1-snapshot-20250117103757yarn add @medusajs/ui-preset@2.2.1-snapshot-20250117103757yarn add @medusajs/medusa@2.2.1-snapshot-20250117103757yarn add @medusajs/telemetry@2.2.1-snapshot-20250117103757yarn add @medusajs/test-utils@2.2.1-snapshot-20250117103757yarn add @medusajs/api-key@2.2.1-snapshot-20250117103757yarn add @medusajs/auth@2.2.1-snapshot-20250117103757yarn add @medusajs/cache-inmemory@2.2.1-snapshot-20250117103757yarn add @medusajs/cache-redis@2.2.1-snapshot-20250117103757yarn add @medusajs/cart@2.2.1-snapshot-20250117103757yarn add @medusajs/currency@2.2.1-snapshot-20250117103757yarn add @medusajs/customer@2.2.1-snapshot-20250117103757yarn add @medusajs/event-bus-local@2.2.1-snapshot-20250117103757yarn add @medusajs/event-bus-redis@2.2.1-snapshot-20250117103757yarn add @medusajs/file@2.2.1-snapshot-20250117103757yarn add @medusajs/fulfillment@2.2.1-snapshot-20250117103757yarn add @medusajs/index@2.2.1-snapshot-20250117103757yarn add @medusajs/inventory@2.2.1-snapshot-20250117103757yarn add @medusajs/link-modules@2.2.1-snapshot-20250117103757yarn add @medusajs/locking@2.2.1-snapshot-20250117103757yarn add @medusajs/notification@2.2.1-snapshot-20250117103757yarn add @medusajs/order@2.2.1-snapshot-20250117103757yarn add @medusajs/payment@2.2.1-snapshot-20250117103757yarn add @medusajs/pricing@2.2.1-snapshot-20250117103757yarn add @medusajs/product@2.2.1-snapshot-20250117103757yarn add @medusajs/promotion@2.2.1-snapshot-20250117103757yarn add @medusajs/auth-emailpass@2.2.1-snapshot-20250117103757yarn add @medusajs/auth-github@2.2.1-snapshot-20250117103757yarn add @medusajs/auth-google@2.2.1-snapshot-20250117103757yarn add @medusajs/file-local@2.2.1-snapshot-20250117103757yarn add @medusajs/file-s3@2.2.1-snapshot-20250117103757yarn add @medusajs/fulfillment-manual@2.2.1-snapshot-20250117103757yarn add @medusajs/locking-postgres@2.2.1-snapshot-20250117103757yarn add @medusajs/locking-redis@2.2.1-snapshot-20250117103757yarn add @medusajs/notification-local@2.2.1-snapshot-20250117103757yarn add @medusajs/notification-sendgrid@2.2.1-snapshot-20250117103757yarn add @medusajs/payment-stripe@2.2.1-snapshot-20250117103757yarn add @medusajs/region@2.2.1-snapshot-20250117103757yarn add @medusajs/sales-channel@2.2.1-snapshot-20250117103757yarn add @medusajs/stock-location@2.2.1-snapshot-20250117103757yarn add @medusajs/store@2.2.1-snapshot-20250117103757yarn add @medusajs/tax@2.2.1-snapshot-20250117103757yarn add @medusajs/user@2.2.1-snapshot-20250117103757yarn add @medusajs/workflow-engine-inmemory@2.2.1-snapshot-20250117103757yarn add @medusajs/workflow-engine-redis@2.2.1-snapshot-20250117103757
|
sradevski
force-pushed
the
feat/add-support-manage-account-holder
branch
from
430878f to
c370fd0
Compare
|
/snapshot-this |
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/admin-bundler@2.2.1-snapshot-20250117121342yarn add @medusajs/admin-sdk@2.2.1-snapshot-20250117121342yarn add @medusajs/admin-shared@2.2.1-snapshot-20250117121342yarn add @medusajs/admin-vite-plugin@2.2.1-snapshot-20250117121342yarn add @medusajs/dashboard@2.2.1-snapshot-20250117121342yarn add create-medusa-app@2.2.1-snapshot-20250117121342yarn add @medusajs/cli@2.2.1-snapshot-20250117121342yarn add medusa-dev-cli@2.2.1-snapshot-20250117121342yarn add @medusajs/medusa-oas-cli@2.2.1-snapshot-20250117121342yarn add @medusajs/core-flows@2.2.1-snapshot-20250117121342yarn add @medusajs/framework@2.2.1-snapshot-20250117121342yarn add @medusajs/js-sdk@2.2.1-snapshot-20250117121342yarn add @medusajs/modules-sdk@2.2.1-snapshot-20250117121342yarn add @medusajs/orchestration@2.2.1-snapshot-20250117121342yarn add @medusajs/types@2.2.1-snapshot-20250117121342yarn add @medusajs/utils@2.2.1-snapshot-20250117121342yarn add @medusajs/workflows-sdk@2.2.1-snapshot-20250117121342yarn add @medusajs/icons@2.2.1-snapshot-20250117121342yarn add @medusajs/ui-preset@2.2.1-snapshot-20250117121342yarn add @medusajs/medusa@2.2.1-snapshot-20250117121342yarn add @medusajs/telemetry@2.2.1-snapshot-20250117121342yarn add @medusajs/test-utils@2.2.1-snapshot-20250117121342yarn add @medusajs/api-key@2.2.1-snapshot-20250117121342yarn add @medusajs/auth@2.2.1-snapshot-20250117121342yarn add @medusajs/cache-inmemory@2.2.1-snapshot-20250117121342yarn add @medusajs/cache-redis@2.2.1-snapshot-20250117121342yarn add @medusajs/cart@2.2.1-snapshot-20250117121342yarn add @medusajs/currency@2.2.1-snapshot-20250117121342yarn add @medusajs/customer@2.2.1-snapshot-20250117121342yarn add @medusajs/event-bus-local@2.2.1-snapshot-20250117121342yarn add @medusajs/event-bus-redis@2.2.1-snapshot-20250117121342yarn add @medusajs/file@2.2.1-snapshot-20250117121342yarn add @medusajs/fulfillment@2.2.1-snapshot-20250117121342yarn add @medusajs/index@2.2.1-snapshot-20250117121342yarn add @medusajs/inventory@2.2.1-snapshot-20250117121342yarn add @medusajs/link-modules@2.2.1-snapshot-20250117121342yarn add @medusajs/locking@2.2.1-snapshot-20250117121342yarn add @medusajs/notification@2.2.1-snapshot-20250117121342yarn add @medusajs/order@2.2.1-snapshot-20250117121342yarn add @medusajs/payment@2.2.1-snapshot-20250117121342yarn add @medusajs/pricing@2.2.1-snapshot-20250117121342yarn add @medusajs/product@2.2.1-snapshot-20250117121342yarn add @medusajs/promotion@2.2.1-snapshot-20250117121342yarn add @medusajs/auth-emailpass@2.2.1-snapshot-20250117121342yarn add @medusajs/auth-github@2.2.1-snapshot-20250117121342yarn add @medusajs/auth-google@2.2.1-snapshot-20250117121342yarn add @medusajs/file-local@2.2.1-snapshot-20250117121342yarn add @medusajs/file-s3@2.2.1-snapshot-20250117121342yarn add @medusajs/fulfillment-manual@2.2.1-snapshot-20250117121342yarn add @medusajs/locking-postgres@2.2.1-snapshot-20250117121342yarn add @medusajs/locking-redis@2.2.1-snapshot-20250117121342yarn add @medusajs/notification-local@2.2.1-snapshot-20250117121342yarn add @medusajs/notification-sendgrid@2.2.1-snapshot-20250117121342yarn add @medusajs/payment-stripe@2.2.1-snapshot-20250117121342yarn add @medusajs/region@2.2.1-snapshot-20250117121342yarn add @medusajs/sales-channel@2.2.1-snapshot-20250117121342yarn add @medusajs/stock-location@2.2.1-snapshot-20250117121342yarn add @medusajs/store@2.2.1-snapshot-20250117121342yarn add @medusajs/tax@2.2.1-snapshot-20250117121342yarn add @medusajs/user@2.2.1-snapshot-20250117121342yarn add @medusajs/workflow-engine-inmemory@2.2.1-snapshot-20250117121342yarn add @medusajs/workflow-engine-redis@2.2.1-snapshot-20250117121342
|
christiananese
approved these changes
Jan 17, 2025
|
Yes definitely, @shahednasser can you have a look and decide what deserves to be documented in the docs? There is the part of There is also the new interface of a payment provider |
olivermrbl
reviewed
Jan 17, 2025
Comment on lines
-281
to
-283
| if (stripeId !== data.customer) { | ||
| return await this.initiatePayment(input) | ||
| } else { |
There was a problem hiding this comment.
question: Don't we need to deal with this scenario still?
- I initialize my cart as a guest customer
- Go through the checkout flow and create payment sessions
- I sign in -> should update the customer on the payment intent
There was a problem hiding this comment.
Actually, I am not sure our workflows are wired up to deal with this right now.
There was a problem hiding this comment.
They are not, and this method is not even called.
I was gonna ask you why https://github.com/medusajs/medusa/pull/9348/files was closed actually, as I imagine that's where these flows would be implemented
sradevski
force-pushed
the
feat/add-support-manage-account-holder
branch
from
c370fd0 to
1b5d9d9
Compare
sradevski
force-pushed
the
feat/add-support-manage-account-holder
branch
from
1b5d9d9 to
35b9fd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING: The
contextanddatafields were removed from the payment session endpoint as they pose a security risk, since they are open-ended.The endpoint should only accept what is absolutely necessary to be provided by the client, nothing more.