Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename the angular distance to cosine distance #94

Merged
merged 1 commit into from
Sep 24, 2024
Merged

rename the angular distance to cosine distance #94

merged 1 commit into from
Sep 24, 2024

Conversation

irevoire
Copy link
Member

Pull Request

Related issue

Fixes #90

What does this PR do?

  • Rename the angular distance to cosine distance
  • same for their binary quantized version

@irevoire irevoire added enhancement New feature or request breaking Something that will break in the next release db-breaking labels Sep 24, 2024
@irevoire irevoire added this to the v0.4.0 milestone Sep 24, 2024
Kerollmops
Kerollmops approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicele!

@Kerollmops Kerollmops merged commit b1b3474 into main Sep 24, 2024
8 checks passed
@Kerollmops Kerollmops deleted the rename-angular-to-cosine branch September 24, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kerollmops Kerollmops Kerollmops approved these changes

Assignees
No one assigned
Labels
breaking Something that will break in the next release db-breaking enhancement New feature or request
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.

Rename Angular to Cosine
2 participants
@irevoire @Kerollmops