Add an option to customize separators #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManyTheFish
force-pushed
the
segment-n-classify-custom-separators
branch
from
cb5ccb4
to
8828b68
Compare
ManyTheFish
requested review from
dureuill and
Kerollmops
and removed request for
dureuill
Kerollmops
approved these changes
Jun 28, 2023
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a pre-segmenter that segments a text based on a separator list possibly given during the Tokenizer's building. Moreover, this separator's list is used by the classifier to categorize a lemma as a separator or not.
These changes highly impact the Hebrew and Latin tokenizers based on Unicode-segmentation:
About Hard separators (or context separators), because I didn't want to rely on deunicode to define a Hard separator and because I didn't manage to find an exhaustive list of "sentence/context separators" (in opposition to word separators), I personally created my own list of context separators based on several Unicode usages and conventions.