Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PTS integrity check crashing with nil pts fix #58

Merged
merged 5 commits into from
Apr 17, 2024
Merged

PTS integrity check crashing with nil pts fix #58

merged 5 commits into from
Apr 17, 2024

Conversation

bartkrak
Copy link
Contributor

@bartkrak bartkrak added the bug Something isn't working label Apr 15, 2024
@bartkrak bartkrak self-assigned this Apr 15, 2024
@bartkrak bartkrak requested review from varsill and FelonEkonom April 15, 2024 22:46
FelonEkonom
FelonEkonom requested changes Apr 16, 2024
View reviewed changes
Copy link
Member

@FelonEkonom FelonEkonom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are OK. Add test checking, if encoder can handle nil timestamps.

@bartkrak bartkrak requested a review from FelonEkonom April 17, 2024 00:07
@bartkrak bartkrak mentioned this pull request Apr 17, 2024
Closed
16 tasks
varsill
varsill approved these changes Apr 17, 2024
View reviewed changes
test/membrane_element_fdk_aac/pts_test.exs Outdated Show resolved Hide resolved
@bartkrak bartkrak merged commit bd42666 into master Apr 17, 2024
3 checks passed
@bartkrak bartkrak deleted the pts_bad_arthmetic_fix branch April 17, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FelonEkonom FelonEkonom FelonEkonom approved these changes

@varsill varsill varsill approved these changes

Assignees

@bartkrak bartkrak

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bartkrak @varsill @FelonEkonom