disable Reviewdog

mercari · Aug 16, 2023 · 8f46f49 · 8f46f49
1 parent 8c2252c
commit 8f46f49
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 637 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -26,7 +26,7 @@ jobs:
       - name: Run test
         run: |
           make test
-  reviewdog:
+  lint:
     permissions:
       contents: read
     runs-on: ubuntu-latest
@@ -45,6 +45,6 @@ jobs:
         if: ${{ steps.setup-go.outputs.cache-hit != 'true' }}
         run: |
           go mod download
-      - name: Run reviewdog
+      - name: Run lint tools
         run: |
-          make reviewdog
+          make lint
diff --git a/.reviewdog.yml b/.reviewdog.yml
@@ -1,13 +1,7 @@
 runner:
   # https://golang.org/cmd/vet/
   govet:
-    cmd: go vet $(go list ./...)
-
-  # https://github.com/golang/lint
-  golint:
-    cmd: golint $(go list ./...)
-    errorformat:
-    - "%f:%l:%c: %m"
+    format: govet
 
   # https://github.com/client9/misspell
   misspell:
@@ -17,7 +11,7 @@ runner:
 
   # https://github.com/kisielk/errcheck
   errcheck:
-    cmd: errcheck -exclude .errcheck_excludes  -ignore 'fmt:.*,io:.*,ioutil:.*,net/http:.*' -ignoretests $(go list ./...)
+    cmd: errcheck -ignore 'fmt:.*,io:.*,ioutil:.*,net/http:.*' -ignoretests $(go list ./...)
     errorformat:
     - "%f:%l:%c:%m"
 

diff --git a/Makefile b/Makefile
@@ -6,8 +6,6 @@ PACKAGES ?= $(shell go list ./...)
 GO_TEST ?= go test
 GO_TEST_TARGET ?= .
 
-REVIEWDOG_ARG ?= -diff="git diff master"
-
 LINT_TOOLS=$(shell cat tools/tools.go | egrep '^\s_ '  | awk '{ print $$2 }')
 
 GOPATH := $(shell go env GOPATH)
@@ -25,14 +23,15 @@ bootstrap-lint-tools:
 test:  ## Run go test
 	${GO_TEST} -v -race -mod=readonly -run=$(GO_TEST_TARGET) $(PACKAGES)
 
+.PHONY: lint
+lint: bootstrap-lint-tools ## Run lint tools
+	go vet ./...
+	staticcheck ./...
+
 .PHONY: coverage
 coverage:  ## Collect test coverage
 	${GO_TEST} -v -race -mod=readonly -run=$(GO_TEST_TARGET) -covermode=atomic -coverpkg=${REPOSITORY}/... -coverprofile=$@.out $(PACKAGES)
 
-.PHONY: reviewdog
-reviewdog: bootstrap-lint-tools  ## Run reviewdog
-	reviewdog -conf=.reviewdog.yml $(REVIEWDOG_ARG)
-
 .PHONY: help
 help:  ## Show this help
 	@awk 'BEGIN {FS = ":.*##"; printf "\nUsage:\n  make \033[33m<target>\033[0m\n\nTargets:\n"} /^[a-zA-Z\/_-]+:.*?##/ { printf "  \033[36m%-15s\033[0m %s\n", $$1, $$2 }' $(MAKEFILE_LIST)
diff --git a/crc16/crc16.go b/crc16/crc16.go
@@ -82,7 +82,7 @@ func (d *digest) Sum16() uint16 { return d.crc }
 
 func (d *digest) Sum(in []byte) []byte {
 	s := d.Sum16()
-	return append(in, byte(s>>16), byte(s>>8), byte(s))
+	return append(in, 0, byte(s>>8), byte(s))
 }
 
 // Hash16 is the common interface implemented by all 16-bit hash functions.

diff --git a/go.mod b/go.mod
@@ -2,65 +2,13 @@ module go.mercari.io/go-emv-code
 
 go 1.21
 
-require (
-	github.com/client9/misspell v0.3.4
-	github.com/kisielk/errcheck v1.6.3
-	github.com/reviewdog/reviewdog v0.14.2
-	golang.org/x/lint v0.0.0-20210508222113-6edffad5e616
-	gotest.tools/gotestsum v1.10.1
-	honnef.co/go/tools v0.4.3
-)
+require honnef.co/go/tools v0.4.3
 
 require (
-	cloud.google.com/go v0.110.0 // indirect
-	cloud.google.com/go/compute v1.18.0 // indirect
-	cloud.google.com/go/compute/metadata v0.2.3 // indirect
-	cloud.google.com/go/datastore v1.11.0 // indirect
 	github.com/BurntSushi/toml v1.2.1 // indirect
-	github.com/ProtonMail/go-crypto v0.0.0-20230217124315-7d5c6f04bbb8 // indirect
-	github.com/bradleyfalzon/ghinstallation/v2 v2.5.0 // indirect
-	github.com/cloudflare/circl v1.3.3 // indirect
-	github.com/dnephin/pflag v1.0.7 // indirect
-	github.com/fatih/color v1.13.0 // indirect
-	github.com/fsnotify/fsnotify v1.5.4 // indirect
-	github.com/golang-jwt/jwt/v4 v4.5.0 // indirect
-	github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
-	github.com/golang/protobuf v1.5.3 // indirect
-	github.com/google/go-cmp v0.5.9 // indirect
-	github.com/google/go-github/v53 v53.1.0 // indirect
-	github.com/google/go-querystring v1.1.0 // indirect
-	github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510 // indirect
-	github.com/googleapis/enterprise-certificate-proxy v0.2.3 // indirect
-	github.com/googleapis/gax-go/v2 v2.7.1 // indirect
-	github.com/hashicorp/go-cleanhttp v0.5.2 // indirect
-	github.com/hashicorp/go-retryablehttp v0.7.2 // indirect
-	github.com/haya14busa/go-actions-toolkit v0.0.0-20200105081403-ca0307860f01 // indirect
-	github.com/mattn/go-colorable v0.1.12 // indirect
-	github.com/mattn/go-isatty v0.0.14 // indirect
-	github.com/mattn/go-shellwords v1.0.12 // indirect
-	github.com/reva2/bitbucket-insights-api v1.0.0 // indirect
-	github.com/reviewdog/errorformat v0.0.0-20230613135350-0fa2b5b7c727 // indirect
-	github.com/reviewdog/go-bitbucket v0.0.0-20201024094602-708c3f6a7de0 // indirect
-	github.com/vvakame/sdlog v1.1.2 // indirect
-	github.com/xanzy/go-gitlab v0.85.0 // indirect
-	go.opencensus.io v0.24.0 // indirect
-	golang.org/x/build v0.0.0-20230616225607-2f704e01b36f // indirect
-	golang.org/x/crypto v0.10.0 // indirect
 	golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a // indirect
 	golang.org/x/mod v0.8.0 // indirect
-	golang.org/x/net v0.11.0 // indirect
-	golang.org/x/oauth2 v0.9.0 // indirect
 	golang.org/x/sync v0.3.0 // indirect
 	golang.org/x/sys v0.9.0 // indirect
-	golang.org/x/term v0.9.0 // indirect
-	golang.org/x/text v0.10.0 // indirect
-	golang.org/x/time v0.3.0 // indirect
 	golang.org/x/tools v0.6.0 // indirect
-	golang.org/x/xerrors v0.0.0-20220907171357-04be3eba64a2 // indirect
-	google.golang.org/api v0.114.0 // indirect
-	google.golang.org/appengine v1.6.7 // indirect
-	google.golang.org/genproto v0.0.0-20230320184635-7606e756e683 // indirect
-	google.golang.org/grpc v1.53.0 // indirect
-	google.golang.org/protobuf v1.30.0 // indirect
-	gopkg.in/yaml.v3 v3.0.1 // indirect
 )