don't update HPA spec if off (#188)

mercari · Oct 13, 2023 · 70b2e6d · 70b2e6d
1 parent d443cdf
commit 70b2e6d
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/pkg/hpa/service.go b/pkg/hpa/service.go
@@ -428,6 +428,11 @@ func (c *Service) ChangeHPAFromTortoiseRecommendation(tortoise *autoscalingv1bet
 }
 
 func (c *Service) UpdateHPASpecFromTortoiseAutoscalingPolicy(ctx context.Context, tortoise *autoscalingv1beta2.Tortoise, dm *v1.Deployment, now time.Time) (*autoscalingv1beta2.Tortoise, error) {
+	if tortoise.Spec.UpdateMode == autoscalingv1beta2.UpdateModeOff {
+		// When UpdateMode is Off, we don't update HPA.
+		return tortoise, nil
+	}
+
 	if !HasHorizontal(tortoise) {
 		err := c.DeleteHPACreatedByTortoise(ctx, tortoise)
 		if err != nil && !apierrors.IsNotFound(err) {