Migrate away from using the .localized string extension which could c… #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ause issues with genstrings
|
Conflicted on this one. Its one of those things that was fine 99% of the time and a decent enough improvement, but caused a missed translation key in a few cases and is unnecessary in others. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the extension on
Stringthat aliasedNSLocalizedString.NSLocalizedStringhas some special magic under the hood that is mean to work specifically with static strings in the source code. By wrapping it in a computed property, a developer could inadvertently think dynamic string content was being localized.While this was fine in the majority of cases. we did find a few where it didn't work. Notably, this was occurring in some of the
localizedextensions on other types, because these types'rawValueis set at runtime.