Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor router state to more closely match tab bar behavior #901

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

72A12F4E
Copy link
Contributor

@72A12F4E 72A12F4E commented Aug 28, 2024

What changed?

This change modifies NavigationState to separately track the tab's selection behavior from the selected tab.

Why did it change?

This should prevent the issue where switching back & forth between messages / other tabs on a phone will leave the app showing the "Select a conversation" screen. This also simplified the Bindings across the root screens for each tab.

How is this tested?

Screenshots/Videos (when applicable)

Checklist

  • My code adheres to the project's coding and style guidelines.
  • I have conducted a self-review of my code.
  • I have commented my code, particularly in complex areas.
  • I have made corresponding changes to the documentation.
  • I have tested the change to ensure that it works as intended.

@72A12F4E
Copy link
Contributor Author

@garthvh I haven't been able to give this a full test cycle yet, but would appreciate a quick look over the changes nonetheless

@garthvh
Copy link
Member

garthvh commented Aug 28, 2024

Seems better than ever being down an extra level, worked better than the current routing for me, bluetooth link in the new live activity still works.

Copy link
Member

@garthvh garthvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and previews work again, I approve

@72A12F4E 72A12F4E marked this pull request as ready for review August 28, 2024 18:41
@72A12F4E 72A12F4E merged commit c678cd3 into main Aug 28, 2024
2 checks passed
@garthvh garthvh deleted the refactor-router-state branch August 28, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants