Changes for 2.5.9 #960
Changes for 2.5.9 #960
Conversation
Add missing timestamps to TraceRoute data structures
…nses, temp layout test
| @@ -56,13 +56,13 @@ struct TraceRoute: Layout { | |||
|
|
|||
| subview.place(at: point, anchor: .center, proposal: .unspecified) | |||
|
|
|||
| DispatchQueue.main.async { | |||
| // DispatchQueue.main.async { | |||
There was a problem hiding this comment.
I was running this branch earlier today and noticed that this change was causing the arrows between nodes to no longer angle correctly. They all pointed one direction until I uncommented these.
There was a problem hiding this comment.
For me, the app crashed when going from a multi-hop traceroute to a direct traceroute in the list. With this, this doesn't happen anymore, but indeed the arrows don't angle correctly anymore.
There was a problem hiding this comment.
Ok. I reproduced that crash. Looks like it's probably referencing the subview data after it's getting torn down.
On the flip side, those assignments in this state trigger a "Modifying state during view update, this will cause undefined behavior” warning.
| } | ||
| hopNodes.append(destinationHop) | ||
| /// Add the destination node to the end of the route towards string and the beginning of teh route back string | ||
| routeString += "\(traceRoute?.node?.user?.longName ?? "unknown".localized) \((traceRoute?.node?.num ?? 0).toHex()) \(traceRoute?.node?.snr ?? 0 > 0 ? traceRoute?.node?.snr ?? 0 : 0.0)dB)" |
There was a problem hiding this comment.
Isn't this checking whether the SNR is > 0? I'm seeing 0.0dB when I expect a negative SNR.
Also, if it's an unknown SNR (due to old firmware), this value will be -128.
There was a problem hiding this comment.
I think it would also be better to use the SNR values from the traceroute and not those corresponding to a node, because those will change when subsequent packets are received.
| connectedHop.time = Date() | ||
| connectedHop.num = connectedPeripheral.num | ||
| connectedHop.name = connectedNode.user?.longName ?? "???" | ||
| connectedHop.snr = Float(routingMessage.snrBack.last ?? 0 / 4) |
There was a problem hiding this comment.
Is 0 / 4 intended here? Seems like this would resolve to 0.
What changed?