Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Change circular traceroute arrows to circles #970

Closed
wants to merge 1 commit into from

Conversation

bjpetit
Copy link
Contributor

@bjpetit bjpetit commented Oct 16, 2024

What changed?

Modify arrows in the circular traceroutes to circles. Yes, this is cheating. But until there is a solution for rotating the arrows used in the circular traceroute, circles could be used.

Why did it change?

I was just looking for a way to enable the circular traceroute while a solution for the arrows is investigated. I admit, this is a bit of a weasely solution, but it enables the traceroute animation, which is valuable.

How is this tested?

Ran through traceroute displays of various hop counts.

Screenshots/Videos (when applicable)

Checklist

  • My code adheres to the project's coding and style guidelines.
  • I have conducted a self-review of my code.
  • I have commented my code, particularly in complex areas.
  • I have made corresponding changes to the documentation.
  • I have tested the change to ensure that it works as intended.

@garthvh garthvh deleted the branch meshtastic:2.5.9 October 19, 2024 15:03
@garthvh garthvh closed this Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants