-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add skip kw to test function #12362
base: master
Are you sure you want to change the base?
add skip kw to test function #12362
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed one small code thing. I don't have an opinion on whether this is a good idea or not, see if anyone else weighs in
I don't understand the purpose of this feature. What does "to keep the test in the list of available tests" mean? It's not actually available. If none of this is suitable, and you just want to keep the test in meson.build, why not comment it out? |
In my monorepo, I have a suite of python tests needing |
I was referred to this PR from here. I just want to support this feature, it addresses a need that we have identified. It would be nice if a reason for the skip could also be given (like in my prototype patch), by an additional string argument somewhere. But that might be out of scope for this patch, looking at how the code is structured. |
rebased and targeted for 1.4.0 |
No description provided.