Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Event Art Archive logos #127

Merged
merged 1 commit into from
May 22, 2024
Merged

Add Event Art Archive logos #127

merged 1 commit into from
May 22, 2024

Conversation

Aerozol
Copy link
Collaborator

@Aerozol Aerozol commented May 22, 2024

Event Art Archive logos of all shapes, sizes and formats that the other logos have. Plus the working files.
The EAA logo is currently the same as the CAA, but the accompanying text has been changed.

Event Art Archive logos of all shapes, sizes and formats that the other logos have.
Plus the working files.
The EAA logo is currently the same as the CAA, but the accompanying text has been changed.
@Aerozol Aerozol merged commit 0ed51e9 into metabrainz:master May 22, 2024
yvanzo added a commit to metabrainz/artwork-redirect that referenced this pull request May 22, 2024
It follows metabrainz/design-system#127

The added EAA navbar logo has been converted using ImageMagick 7.1.1:

    convert EventArtArchive_logo_mini.svg -geometry 255x28 navbar_eaa_logo.svg
yvanzo added a commit to metabrainz/artwork-redirect that referenced this pull request May 22, 2024
It follows metabrainz/design-system#127

The HTML code for PNG icons is taken from OfficeBrainz/ListenBrainz,
and the HTML code for the ICO fallback is taken from MusicBrainz.

After copying the ICO files from design-system, these are converted
using ImageMagick 7.1.1 and then compressed using ZopfliPNG 1.0.3:

    convert favicon-caa.ico favicon-caa.png
    for f in favicon-caa-*.png
    do
        g="favicon-eaa-$(identify $f | sed 's/.*\s\([0-9]*\)x.*/\1/').png"
        zopflipng --iterations=3 --filters=01234meb --lossy_8bit --lossy_transparent "$f" "$g"
        rm -f "$f"
    done

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The left side of this icon looks broken to me 🔍

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it looks good on my end, in browser. What are you seeing?

image

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both the preview on GitHub and the SVG in a Firefox 126 tab look like this for me:
image
I have now downloaded the file and it looks fine in Inkscape and LibreOffice 😕
Something is different with this SVG, all others are rendered just fine...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does the one in this folder look?
https://github.com/metabrainz/design-system/tree/master/brand/logos/Cover%20Art%20Archive/icons
They are the same image after all! If you have the same trouble there I will mess with the export settings.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue, I just had not seen that image yet.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That one is good, it looks fine in both Firefox and Inkscape. Thank you very much!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Please let me know if you spot any issues in #128
And if you ever feel like making 'real' ico files, go for it ;)

yvanzo added a commit to metabrainz/artwork-redirect that referenced this pull request May 22, 2024
It follows metabrainz/design-system#127

The added EAA navbar logo has been cropped using Inkscape 1.3.2:

    inkscape -D -l -o navbar_eaa_logo.svg EventArtArchive_logo_mini.svg
yvanzo added a commit to metabrainz/artwork-redirect that referenced this pull request May 22, 2024
It follows metabrainz/design-system#127

The HTML code for PNG icons is taken from OfficeBrainz/ListenBrainz,
and the HTML code for the ICO fallback is taken from MusicBrainz.

After copying the ICO files from design-system, these are converted
using ImageMagick 7.1.1 and then compressed using ZopfliPNG 1.0.3:

    convert favicon-caa.ico favicon-caa.png
    for f in favicon-caa-*.png
    do
        g="favicon-eaa-$(identify $f | sed 's/.*\s\([0-9]*\)x.*/\1/').png"
        zopflipng --iterations=3 --filters=01234meb --lossy_8bit --lossy_transparent "$f" "$g"
        rm -f "$f"
    done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants