Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @crossdomain decorator to nag-check endpoint #494

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

MonkeyDo
Copy link
Member

Calling the nag-check from the ListenBrainz website results in a CORS error. I proposed adding the crossdomain decorator to fix that, confirmed by rob: https://chatlogs.metabrainz.org/libera/metabrainz/2024-11-28/?msg=5404970&page=1

Copy link

github-actions bot commented Dec 17, 2024

Test Results

179 tests  ±0   174 ✅ ±0   26s ⏱️ ±0s
  1 suites ±0     5 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 922f935. ± Comparison against base commit fe42b16.

♻️ This comment has been updated with latest results.

@MonkeyDo MonkeyDo requested a review from mayhem December 17, 2024 16:25
Calling the nag-check from the ListenBrainz website results in a CORS error.
I proposed adding the crossdomain decorator to fix that, confirmed by rob: https://chatlogs.metabrainz.org/libera/metabrainz/2024-11-28/?msg=5404970&page=1
Copy link
Member

@mayhem mayhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MonkeyDo MonkeyDo merged commit b0cd5c2 into master Dec 18, 2024
2 checks passed
@MonkeyDo MonkeyDo deleted the nag-check-cors branch December 18, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants