Skip to content

Commit

Permalink
Revert Fix, fix tests
Browse files Browse the repository at this point in the history
  • Loading branch information
jakeschuurmans committed Aug 6, 2024
1 parent cdfeb72 commit f5841ff
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
12 changes: 6 additions & 6 deletions controller_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -110,42 +110,42 @@ func TestStateFinalized(t *testing.T) {
conditionID: uuid.New(),
state: inProgress,
expectMethod: "inProgress",
expectBool: false,
expectBool: true,
},
{
name: "Condition complete",
conditionID: uuid.New(),
state: complete,
expectMethod: "complete",
expectBool: false,
expectBool: true,
},
{
name: "Condition orphaned",
conditionID: uuid.New(),
state: orphaned,
expectMethod: "inProgress",
expectBool: true,
expectBool: false,
},
{
name: "Condition not started",
conditionID: uuid.New(),
state: notStarted,
expectMethod: "inProgress",
expectBool: true,
expectBool: false,
},
{
name: "Condition state indeterminate",
conditionID: uuid.New(),
state: indeterminate,
expectMethod: "nak",
expectBool: false,
expectBool: true,
},
{
name: "Condition state unexpected",
conditionID: uuid.New(),
state: 99, // unexpected lifecycle state
expectMethod: "complete",
expectBool: false,
expectBool: true,
},
}

Expand Down
2 changes: 1 addition & 1 deletion task.go
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ func NewNatsConditionTaskRepository(
conditionKind: conditionKind,
controllerID: controllerID.String(),
serverID: serverID,
bucketName: string(conditionKind),
bucketName: condition.TaskKVRepositoryBucket,
log: logger,
}

Expand Down

0 comments on commit f5841ff

Please sign in to comment.