Skip to content

Commit

Permalink
inband/action: fail if no update utility was identified
Browse files Browse the repository at this point in the history
  • Loading branch information
joelrebel committed Aug 22, 2024
1 parent 6ba1807 commit c455efa
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion internal/inband/actions.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import (
"github.com/pkg/errors"
"github.com/sirupsen/logrus"

ironlibactions "github.com/metal-toolbox/ironlib/actions"
imodel "github.com/metal-toolbox/ironlib/model"
)

Expand Down Expand Up @@ -100,7 +101,11 @@ func (i *ActionHandler) ComposeAction(ctx context.Context, actionCtx *runner.Act
component.Model,
)
if err != nil {
// not a fatal error
// fatal error only if the updater utility is not identified
if errors.Is(err, ironlibactions.ErrUpdaterUtilNotIdentified) {
return nil, err
}

i.handler.logger.WithFields(logrus.Fields{
"component": actionCtx.Firmware.Component,
"model": actionCtx.Firmware.Models,
Expand Down

0 comments on commit c455efa

Please sign in to comment.