log.Fatal() doesn't require os.Exit() afterwards

metal-toolbox · Jul 31, 2023 · 866a47e · 866a47e
1 parent 4e3ec2e
commit 866a47e
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/cmd/create/firmware_set.go b/cmd/create/firmware_set.go
@@ -3,7 +3,6 @@ package create
 import (
 	"fmt"
 	"log"
-	"os"
 
 	"github.com/google/uuid"
 	mctl "github.com/metal-toolbox/mctl/cmd"
@@ -46,8 +45,7 @@ var createFirmwareSet = &cobra.Command{
 		for _, id := range definedfirmwareSetFlags.AddFirmwareUUIDs {
 			_, err = uuid.Parse(id)
 			if err != nil {
-				log.Println(err.Error())
-				os.Exit(1)
+				log.Fatal(err)
 			}
 
 			payload.ComponentFirmwareUUIDs = append(payload.ComponentFirmwareUUIDs, id)

diff --git a/cmd/edit/firmware_set.go b/cmd/edit/firmware_set.go
@@ -3,7 +3,6 @@ package edit
 import (
 	"fmt"
 	"log"
-	"os"
 
 	"github.com/google/uuid"
 	mctl "github.com/metal-toolbox/mctl/cmd"
@@ -57,7 +56,6 @@ var editFirmwareSet = &cobra.Command{
 				_, err = uuid.Parse(id)
 				if err != nil {
 					log.Fatal(err)
-					os.Exit(1)
 				}
 
 				payload.ComponentFirmwareUUIDs = append(payload.ComponentFirmwareUUIDs, id)
@@ -83,7 +81,6 @@ var editFirmwareSet = &cobra.Command{
 				_, err = uuid.Parse(id)
 				if err != nil {
 					log.Fatal(err)
-					os.Exit(1)
 				}
 
 				payload.ComponentFirmwareUUIDs = append(payload.ComponentFirmwareUUIDs, id)