Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements an HTTP based controller #77

Closed
wants to merge 11 commits into from
Closed

Implements an HTTP based controller #77

wants to merge 11 commits into from

Conversation

joelrebel
Copy link
Member

@joelrebel joelrebel commented Jul 18, 2024 •
edited
Loading

TODO: unit test cases

@joelrebel
events/controller: TaskHandler interface replaces ConditionHandler in…
2bedbbb 
…terface

The Controller handler method is updated to pass in the Task type,
instead of the Condition type, this allows the handler to deal with the
Task type and leave the Condition handling to the library.
@joelrebel
events/controller: generate mocks based on updated interfaces
782c9d1
@joelrebel
events/controller: split Condition lifecycle state check into its own…
313e53c 
… method
@joelrebel
events/controller: init ConditionStatusQueryor right before use
60fff6a 
so we're passing it through a bit less
@joelrebel
events/controller: runConditionHandlerWithMonitor -> runTaskHandlerWi…
b78b0f2 
…thMonitor

This method is passed the Task from the original Condition,
Controllers are passed the Task object and don't have to deal with a Condition
object anymore
@joelrebel
events/controller: update tests for changes
878eb15
@joelrebel
go: updated deps
be0d8f2
@joelrebel
events/controller: rename files
5d5bc0a
@joelrebel
controller/liveness: Add HTTP based liveness client implementation
50912b8
@joelrebel
events/controller: Add HTTP based NATS controller
ee87e8e
Base automatically changed from taskhandler to main July 22, 2024 12:52
@joelrebel
Copy link
Member Author

implemented here metal-toolbox/ctrl#17

@joelrebel joelrebel closed this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@joelrebel