Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed broken link reference to CRs #447

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

chibuikeIg
Copy link

@chibuikeIg chibuikeIg commented Jun 14, 2024

Which problem is this PR solving?

Closes issue: Fix dead links at crs_reference.md #446
Fixes: #446

Description of the changes

Changed from https://github.com/metal3-io/metal3-dev-env/tree/master/crs to https://github.com/metal3-io/metal3-dev-env/tree/b5a53ecf9576c6deab81f692733782d4c5e8091a/crs

How was this change tested?

Ensured the link works both on Browser and when clicked on the Doc.

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dtantsur for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 14, 2024
@metal3-io-bot
Copy link
Contributor

Hi @chibuikeIg. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 14, 2024
@tuminoid
Copy link
Member

Thanks for the PR! Please fix the DCO (sign-off the commit) and repush.

/ok-to-test
/cc @kashifest

PTAL if the linking the last version of the CRS is the right link to replace the dead link, or was the content actually migrated elsewhere.
/hold

@metal3-io-bot metal3-io-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 17, 2024
chibuikeIg and others added 3 commits June 17, 2024 19:55
Signed-off-by: chibuikeIg <paulchibuikeigweze@gmail.com>
Update version support tables with information abotu ironic-image
tags and releases.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
Signed-off-by: chibuikeIg <paulchibuikeigweze@gmail.com>
Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
Signed-off-by: chibuikeIg <paulchibuikeigweze@gmail.com>
@metal3-io-bot metal3-io-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 17, 2024
@dtantsur
Copy link
Member

PTAL if the linking the last version of the CRS is the right link to replace the dead link, or was the content actually migrated elsewhere.

I think it was migrated under the base subdirectory, and indeed we should link to the most recent version.

@kashifest
Copy link
Member

I think this whole crs_reference.md file is obsolete, its still pointing to cluster-api-provider-baremetal! and v1a2 and v1a3 of apis, the crs are non existent in dev-env since I believe

@tuminoid
Copy link
Member

We have two contradicting opinions it seems. It is the only file in the root of the repo and indeed looks obsolete, so insttead of fixing the link we could delete the whole file? @dtantsur @kashifest

@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Aug 15, 2024
@metal3-io-bot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix dead links at crs_reference.md
5 participants