Deprecating sized collection fields #1141
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blockiosaurus
requested review from
febo and
danenbm
and removed request for
a team
danenbm
approved these changes
Jul 13, 2023
febo
reviewed
Jul 18, 2023
| @@ -55,6 +55,10 @@ impl CollectionAuthorityRecord { | |||
| #[cfg_attr(feature = "serde-feature", derive(Serialize, Deserialize))] | |||
| #[derive(BorshSerialize, BorshDeserialize, PartialEq, Eq, Debug, Clone)] | |||
| pub enum CollectionDetails { | |||
| #[deprecated( | |||
| since = "1.13.0", | |||
There was a problem hiding this comment.
I think we need to update the version to the actual version where the deprecated message will show up.
|
@blockiosaurus We probably need to move this PR to the new repository. |
|
PR moved to the new mpl token metadata repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.