Express some higher order functions in terms of other #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapogolions
changed the title
mapogolions
requested review from
JuliaGerasymenko,
SemenchenkoVitaliy and
tshemsedinov
and removed request for
SemenchenkoVitaliy and
JuliaGerasymenko
Co-Authored-By: Vitaliy Semenchenko <semenchenkovitaliy@gmail.com>
DzyubSpirit
requested changes
Jan 19, 2020
| const metasync = require('..'); | ||
| const metatests = require('metatests'); | ||
|
|
||
| metatests.test('findIndex with error', test => { |
There was a problem hiding this comment.
Tests are good 👍
Just nitpicking a grammar, not that important ;-)
Suggested change
| metatests.test('findIndex with error', test => { | |
| metatests.test('findIndex with an error', test => { |
| }); | ||
| }); | ||
|
|
||
| metatests.test('with empty array', test => { |
There was a problem hiding this comment.
Suggested change
| metatests.test('with empty array', test => { | |
| metatests.test('with an empty array', test => { |
| ); | ||
| }); | ||
|
|
||
| metatests.test('with array without element which is searching', test => { |
There was a problem hiding this comment.
Suggested change
| metatests.test('with array without element which is searching', test => { | |
| metatests.test('with an array not containing the searched element', test => { |
| done(err, err ? undefined : false); | ||
| return; | ||
| } | ||
| done(null, true); |
There was a problem hiding this comment.
Suggested change
| done(null, true); | |
| done(null, index !== -1); |
And then it's possible to simplify the check upper to
if (err) {
done(err);
return;
}
|
|
||
| if (len > 0) next(); | ||
| else done(null, false); | ||
| done(null, true); |
|
Thanks, I really appreciate it. I found a problem that could affect the future of this pull request (#442). I will resolve all conversions above as soon as this issue is resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.