Replace spacebars.dot with rewritten version, fixing promises returning functions #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DanielDornhardt can you please update this with the latest changes from the 3.0 branch? Thanks! |
|
@DanielDornhardt what's the status here? Do you want to meet and discuss how we move on with it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, the original "asyncified"
Spacebars.dotdidn't support functions returned from async functions... which might be a bit over the top, but supported is supported.I think this should work as a drop-in replacement for the old
spacebars.dot, but please review & check it. If this is not A++ feel free to take this as an encouragement to support functions returned fromasyncsteps during thedotresolution... :)