Fixer for MA0008 adds using directive automatically (#450)

meziantou · Feb 20, 2023 · f5418d3 · f5418d3
1 parent 1e4741c
commit f5418d3
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/Meziantou.Analyzer/Rules/UseStructLayoutAttributeFixer.cs b/src/Meziantou.Analyzer/Rules/UseStructLayoutAttributeFixer.cs
@@ -8,6 +8,7 @@
 using Microsoft.CodeAnalysis.CodeFixes;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.Editing;
+using Microsoft.CodeAnalysis.Simplification;
 
 namespace Meziantou.Analyzer.Rules;
 
@@ -55,12 +56,12 @@ private static async Task<Document> Refactor(Document document, SyntaxNode nodeT
             return document;
 
         var attribute = editor.Generator.Attribute(
-            generator.TypeExpression(structLayoutAttribute, addImport: true),
+            generator.TypeExpression(structLayoutAttribute).WithAdditionalAnnotations(Simplifier.AddImportsAnnotation),
             new[]
             {
                 generator.AttributeArgument(
                     generator.MemberAccessExpression(
-                        generator.TypeExpression(layoutKindEnum, addImport: true),
+                        generator.TypeExpression(layoutKindEnum).WithAdditionalAnnotations(Simplifier.AddImportsAnnotation),
                         layoutKind.ToString())),
             });
 

diff --git a/tests/Meziantou.Analyzer.Test/Rules/UseStructLayoutAttributeAnalyzerTests.cs b/tests/Meziantou.Analyzer.Test/Rules/UseStructLayoutAttributeAnalyzerTests.cs
@@ -37,7 +37,9 @@ public async Task MissingAttribute_ShouldReportDiagnostic()
     int a;
     int b;
 }";
-        const string CodeFix = @"[System.Runtime.InteropServices.StructLayout(System.Runtime.InteropServices.LayoutKind.Auto)]
+        const string CodeFix = @"using System.Runtime.InteropServices;
+
+[StructLayout(LayoutKind.Auto)]
 struct TypeName
 {
     int a;
@@ -132,7 +134,9 @@ public async Task RecordStruct()
     {
         const string SourceCode = @"record struct [||]TypeName(int A, int B);";
 
-        const string CodeFix = @"[System.Runtime.InteropServices.StructLayout(System.Runtime.InteropServices.LayoutKind.Auto)]
+        const string CodeFix = @"using System.Runtime.InteropServices;
+
+[StructLayout(LayoutKind.Auto)]
 record struct TypeName(int A, int B);";
 
         await CreateProjectBuilder()