-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: logic for archiving dataroom #1051
base: main
Are you sure you want to change the base?
Conversation
@Khaan25 is attempting to deploy a commit to the mftsio Team on Vercel. A member of the Team first needs to authorize it. |
All contributors have signed the CLA ✍️ ✅ |
@Khaan25 looks good so far
|
Yes, I'm gonna work on it |
Hey, In the Link table, we've isArchived field, is that for any other usecase? |
Here's a video: https://streamable.com/0yl2ym Could not upload more than 10 MBs of video on GitHub :) |
…/Khaan25/papermark into feat/ability-to-archive-dataroom
You can see the image above, if we're on trial and we create dataroom then the trial-banner day isn't showing because it's fetching from the first data-room tab in the image, how about we proceed? My initial thoughts are, query for first tab, if null then query for second tab, that way we won't have "days left" but "X days left" What do you say? |
Don't worry about that trial banner. it's a minor thing |
Alright. So we should mark this issue as complete? |
@Khaan25 please sign the CLA as indicated above |
/recheck |
recheck |
I have read the CLA Document and I hereby sign the CLA |
@mfts I've signed it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes, see inline comments.
Ideally we want to reduce code duplication
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a redundant endpoint.
Better to add a "archived" query to GET /datarooms endpoint and then based on that return either all archived or non-archived documents.
Especially since this endpoint is not returning any more information than the index.ts
pages/view/[linkId]/index.tsx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be replicated on /view/domains/[domain]/[slug]/index.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the URL or a button to view view/domains/[domain]/[slug] route?
Sure, I'll do it and let you know |
@mfts I've pushed the changes, can you please review? |
…/Khaan25/papermark into feat/ability-to-archive-dataroom
@Khaan25 looks good. I will make some small changes today and then push it |
Cool |
@mfts, Could you please review and give points? :) |
/award 200 still requires changes from my end |
Awarding Khaan25: 200 points 🕹️ Well done! Check out your new contribution on oss.gg/Khaan25 |
This PR fixes: #785
I've included a boolean in the function to archive a dataroom.
Will discuss some key points with @mfts and finish this feature.