feat: Add invite link functionality to team #1168

ShreyasLakhani · 2024-10-20T08:27:28Z

Summary: This PR introduces the ability for teams to invite members using a unique share link, secured by UUIDs. Previously, team invitations were sent individually via email. This update enhances the invitation process. #1049

Added a new inviteLink field to the Team table in the database
- Type: UUID
- Generated automatically when a new team is created
- Can be reset by team administrators
Implemented functionality to generate and reset the invite link
Created API endpoints for:
- Retrieving the current invite link
- Resetting the invite link
- Joining a team using the invite link
Updated the UI to display and manage the team invite link

The invite link is unique to each team
Team administrators can reset the link if needed
The existing functionality to invite users individually by email is preserved
Thoroughly tested the invite link functionality using Postman:
- Verified the generation of a valid invite link
- Tested the reset functionality for the invite link
- Confirmed successful team joining process using the invite link

2024-10-20.13-37-44.mp4

vercel · 2024-10-20T08:27:32Z

@ShreyasLakhani is attempting to deploy a commit to the mftsio Team on Vercel.

A member of the Team first needs to authorize it.

ShreyasLakhani · 2024-10-20T08:30:14Z

@mfts I migration folder I change code because of veriable conflict. Initially I used "shareLink " in prisma but in code I used "inviteLink" . So i changed all name and use single name "inviteLink".

Let me know, if any error occur.

mfts

Great start! There are a couple of comments for improvement and changes.

One thing I didn't see is how the user actually signs up using the invite link. I think that part is missing or I missed it in the review somehow.

mfts · 2024-10-20T13:25:19Z

pages/api/teams/[teamId]/invite-link.ts

+import { v4 as uuidv4 } from 'uuid';
+
+const generateUniqueInviteLink = (): string => {
+  return `https://papermark.com/teams/invite/${uuidv4()}`;
+};


could you use nanoid() instead of uuid.

mfts · 2024-10-20T13:26:06Z

pages/api/teams/[teamId]/invite-link.ts

+        const newLink = generateUniqueInviteLink();
+        const updatedTeam = await prisma.team.update({
+          where: { id: teamId },
+          data: { inviteLink: newLink },


also let's only store the unique code for each team, not the full URL

this appears in several other places

mfts · 2024-10-20T13:27:54Z

pages/api/teams/[teamId]/invite.ts

you don't need to change this file. this is not related to the team invite link

mfts · 2024-10-20T13:28:39Z

prisma/migrations/20241020070237_add_invite_link_to_team.sql/migration.sql

+-- AlterTable
+DO $$ 
+BEGIN
+    IF EXISTS (SELECT 1 FROM information_schema.columns WHERE table_name = 'Team' AND column_name = 'inviteLink') THEN
+        ALTER TABLE "Team" DROP COLUMN "inviteLink";
+    END IF;
+END $$;
+


I understand that you changed the schema locally for yourself, but please remove this from the migration

mfts · 2024-10-20T13:28:53Z

prisma/schema.prisma

@@ -84,6 +84,8 @@ model Team {

  createdAt DateTime @default(now())
  updatedAt DateTime @updatedAt
+
+  inviteLink String? @unique // Add this line for the unique share link


I think a more appropriate field name is inviteCode

mfts · 2024-10-20T13:30:05Z

components/teams/add-team-member-modal.tsx

+        <div className="mb-4">
+          <Label className="opacity-80">Or share invite link</Label>
+          <Input
+            value={inviteLink || ""}
+            readOnly
+            className="mt-1 w-full"
+          />
+          <div className="mt-2 flex justify-between">
+            <Button 
+              onClick={handleCopyInviteLink} 
+              disabled={!inviteLink || inviteLinkLoading}
+              className="flex-1 mr-2"
+            >
+              Copy Link
            </Button>
-          </DialogFooter>
-        </form>
+            <Button 
+              onClick={handleResetInviteLink} 
+              disabled={inviteLinkLoading}
+              className="flex-1"
+            >
+              Reset Link
+            </Button>
+          </div>
+        </div>


please add the invite by link as a separate dialog / modal

@mfts
I made all changes but I did not understand last changes you told me.
"please add the invite by link as a separate dialog / modal".

@ShreyasLakhani instead of adding the button with the copy invite link on the add-team-member-modal.tsx, please create a new component only for copying the invite link. and that should be a separate button on the /people page.

AndrewHamal · 2024-10-20T18:03:52Z

/assign

oss-gg · 2024-10-20T18:03:54Z

The /assign command can only be used on issues, not on pull requests.

pikachusensei · 2024-10-20T18:20:10Z

/assign

oss-gg · 2024-10-20T18:20:12Z

The /assign command can only be used on issues, not on pull requests.

ShreyasLakhani

@mfts check my PR and give me feedback.

ShreyasLakhani · 2024-10-22T06:42:45Z

@mfts if anything missing or not done please tell me.
I didn't understand "please add the invite by link as a separate dialog / modal" and also I try to solve "One thing I didn't see is how the user actually signs up using the invite link. I think that part is missing or I missed it in the review somehow" this.

mfts

Some changes requested. Let me know if you have a question :)

mfts · 2024-10-22T10:17:41Z

components/teams/add-team-member-modal.tsx

+        <div className="mb-4">
+          <Label className="opacity-80">Or share invite link</Label>
+          <Input
+            value={inviteLink || ""}
+            readOnly
+            className="mt-1 w-full"
+          />
+          <div className="mt-2 flex justify-between">
+            <Button 
+              onClick={handleCopyInviteLink} 
+              disabled={!inviteLink || inviteLinkLoading}
+              className="flex-1 mr-2"
+            >
+              Copy Link
            </Button>
-          </DialogFooter>
-        </form>
+            <Button 
+              onClick={handleResetInviteLink} 
+              disabled={inviteLinkLoading}
+              className="flex-1"
+            >
+              Reset Link
+            </Button>
+          </div>
+        </div>


@ShreyasLakhani instead of adding the button with the copy invite link on the add-team-member-modal.tsx, please create a new component only for copying the invite link. and that should be a separate button on the /people page.

prisma/schema.prisma

mfts · 2024-10-22T10:20:09Z

pages/api/teams/[teamId]/invite-link.ts

+          where: { id: teamId },
+          data: { inviteCode: newCode }, // Store the unique code in inviteCode
+        });
+        return res.json({ inviteLink: `https://papermark.com/teams/invite/${newCode}` }); // Return the full invite link


this should be app.papermark.io but better to use process.env.NEXTAUTH_URL.

also there should be a page for the accepting the invite code as the url indicates. so pages/teams/invite/[code]/index.tsx that's currently missing.

mfts · 2024-10-22T10:21:00Z

pages/api/auth/[...nextauth].ts

don't think this is relevant here if you let the user accept the invite on a dedicated page.

ShreyasLakhani

@mfts all changes you mentioned I have completed.

Let me know, If anything I miss.

ShreyasLakhani · 2024-10-26T07:42:12Z

@mfts can you please review my changes before end of hacktoberfest.

mfts · 2024-10-26T10:30:42Z

@ShreyasLakhani will review your PR tomorrow.

and don't worry will award before end of hacktoberfest :)

ShreyasLakhani · 2024-10-30T16:22:39Z

@mfts Brother, I respect your time but You said that you will review.
still no update on it and hacktoberfest and oss.gg is about to end.

I request to review or proceed award.

mfts

Mentioned a couple of things inline.

package.json

pages/teams/invite/[code]/index.tsx

components/teams/add-team-member-modal.tsx

mfts · 2024-10-31T07:35:06Z

@ShreyasLakhani great progress, I mentioned the change requests inline.

I'm happy to award you 50% of the points now for the work already done. would love to push this over the line with your help.

/award 375

oss-gg · 2024-10-31T07:35:12Z

Awarding ShreyasLakhani: 375 points 🕹️ Well done! Check out your new contribution on oss.gg/ShreyasLakhani

ShreyasLakhani · 2024-10-31T10:19:11Z

@mfts Look at the changes I made.

create new file for invite-link modal (components/teams/invite-link-modal.tsx)
add accept and reject button along with error handling and build regular functions (pages/teams/invite/[code]/index.tsx)
use swr instead of useEffect (components/teams/add-team-member-modal.tsx)
removed uuid package

mfts · 2024-10-31T12:45:35Z

/award 375

Thanks @ShreyasLakhani awarding the second half. will review tomorrow and then hopefully can merge it in

oss-gg · 2024-10-31T12:45:38Z

Awarding ShreyasLakhani: 375 points 🕹️ Well done! Check out your new contribution on oss.gg/ShreyasLakhani

ShreyasLakhani

Please check @mfts

vercel · 2024-12-05T09:29:28Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
papermark	❌ Failed (Inspect)			Dec 5, 2024 9:31am

ShreyasLakhani · 2025-01-11T20:19:52Z

@mfts can you give me any updates regarding this PR?

Add invite link functionality to team

1a6ab26

ShreyasLakhani requested a review from mfts as a code owner October 20, 2024 08:27

mfts requested changes Oct 20, 2024

View reviewed changes

mfts added 🕹️ oss.gg 🕹️ 750 points revisit Currently not required but important in the future iteration-1 labels Oct 20, 2024

Addressed feedback from PR review

492e89f

ShreyasLakhani requested a review from mfts October 22, 2024 06:33

delete migration

a8e99a4

ShreyasLakhani commented Oct 22, 2024

View reviewed changes

mfts requested changes Oct 22, 2024

View reviewed changes

mfts added iteration-2 and removed iteration-1 labels Oct 22, 2024

ShreyasLakhani added 2 commits October 22, 2024 19:37

Add inviteCode field to Team model

e195e92

Addressed PR feedback and made necessary changes

329a4c8

ShreyasLakhani commented Oct 22, 2024

View reviewed changes

ShreyasLakhani requested a review from mfts October 22, 2024 15:25

Merge branch 'main' into invite-link

119ae18

mfts removed the revisit Currently not required but important in the future label Oct 31, 2024

mfts removed the iteration-2 label Oct 31, 2024

mfts requested changes Oct 31, 2024

View reviewed changes

mfts added revisit Currently not required but important in the future iteration-3 labels Oct 31, 2024

Addressed review comments and made necessary changes

165157f

ShreyasLakhani requested a review from mfts October 31, 2024 10:13

mfts added ready-for-review awarded and removed 🕹️ 750 points labels Oct 31, 2024

ShreyasLakhani commented Nov 3, 2024

View reviewed changes

Merge branch 'main' into invite-link

ce4c858

vercel bot had a problem deploying to Preview December 5, 2024 09:31 Failure

feat: Add invite link functionality to team #1168

Are you sure you want to change the base?

feat: Add invite link functionality to team #1168

Conversation

ShreyasLakhani commented Oct 20, 2024

vercel bot commented Oct 20, 2024

ShreyasLakhani commented Oct 20, 2024 • edited Loading

mfts left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ShreyasLakhani Oct 22, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AndrewHamal commented Oct 20, 2024

oss-gg bot commented Oct 20, 2024

pikachusensei commented Oct 20, 2024

oss-gg bot commented Oct 20, 2024

ShreyasLakhani left a comment

Choose a reason for hiding this comment

ShreyasLakhani commented Oct 22, 2024

mfts left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ShreyasLakhani left a comment • edited Loading

Choose a reason for hiding this comment

ShreyasLakhani commented Oct 26, 2024

mfts commented Oct 26, 2024

ShreyasLakhani commented Oct 30, 2024

mfts left a comment

Choose a reason for hiding this comment

mfts commented Oct 31, 2024

oss-gg bot commented Oct 31, 2024

ShreyasLakhani commented Oct 31, 2024

mfts commented Oct 31, 2024

oss-gg bot commented Oct 31, 2024

ShreyasLakhani left a comment

Choose a reason for hiding this comment

vercel bot commented Dec 5, 2024 • edited Loading

ShreyasLakhani commented Jan 11, 2025

ShreyasLakhani commented Oct 20, 2024 •

edited

Loading

ShreyasLakhani Oct 22, 2024 •

edited

Loading

ShreyasLakhani left a comment •

edited

Loading

vercel bot commented Dec 5, 2024 •

edited

Loading