Removed strict version dependency to selenium #109
Conversation
Update the chromedriver for linux to latest available
|
|
|
I made minor changes to setup.py file to remove the strict version dependency to selenium and I have updated the chromedriver version for linux to the latest one available |
helium/_impl/selenium_wrappers.py
Outdated
| # Selenium sometimes returns None. For robustness, we turn this into []: | ||
| return self.target.find_elements_by_css_selector(selector) or [] | ||
| return self.target.find_elements(by, xpath) or [] | ||
| #def find_elements_by_name(self, name): |
There was a problem hiding this comment.
I appreciate the PR. But please don't have dead (commented-out) code in your PR. I will not ever have dead code in my repositories.
| @@ -13,7 +13,7 @@ | |||
| packages = find_packages(exclude=['tests', 'tests.*']), | |||
| install_requires = [ | |||
| # Also update requirements/base.txt when you make changes here. | |||
| 'selenium==3.141.0' | |||
| 'selenium>=3.141.0' | |||
There was a problem hiding this comment.
This permits Selenium 3.141.0. Will your By. changes still work with Selenium 3?
There was a problem hiding this comment.
I suppose that to support both major release, a version check must be added.
| ) |
There was a problem hiding this comment.
Please don't unnecessarily change the white space. See https://gist.github.com/mherrmann/5ce21814789152c17abd91c0b3eaadca.
There was a problem hiding this comment.
I immagine this is due to my editor settings.
|
Hello Michael, are you now happy with the pull request? |
|
I'm afraid the changes do not work for me. I have Selenium 4.10.0 and am getting: Please see "Contributing" in https://github.com/mherrmann/selenium-python-helium#Contributing for how to run the tests and reproduce this for yourself. You'll manually need to install |
|
desired_capabilities is deprecated in Selenium 4, can only use browser options |
Update the chromedriver for linux to latest available