Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new derived store for possibly updated domain #214

Merged
merged 4 commits into from
Jun 23, 2024

Conversation

jnsprnw
Copy link
Contributor

@jnsprnw jnsprnw commented Jun 20, 2024

This is a quick draft and suggestion of how to fix #213.

Resetting $domain in createScale.js did not work as the function has no access to the domain store from the upper level.

This solution is not the most elegant, but I couldn’t find another one yet.

This is a quick draft and suggestion of how to fix mhkeller#213.
@mhkeller
Copy link
Owner

That seems like a pretty light-touch way to do it. Let me think on it a bit if there are any alternatives. Thanks a bunch for digging into it!

@mhkeller mhkeller marked this pull request as ready for review June 22, 2024 21:37
@mhkeller
Copy link
Owner

@jnsprnw How's that look now?

@techniq
Copy link
Contributor

techniq commented Jun 22, 2024

I ran into this as well and just used $xScale.domain()/etc instead :).

Nice to not have to know this and work around.

@mhkeller mhkeller merged commit 5afc277 into mhkeller:main Jun 23, 2024
4 checks passed
@jnsprnw
Copy link
Contributor Author

jnsprnw commented Jun 28, 2024

Thanks so much for the quick merge!

@mhkeller
Copy link
Owner

Thanks for the quick PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$domain does not reflect .nice()
3 participants