Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-commit: handle *.md files with mdformat + apply it #12

Merged
merged 2 commits into from
Dec 30, 2023
Merged

pre-commit: handle *.md files with mdformat + apply it #12

merged 2 commits into from
Dec 30, 2023

Conversation

dbast
Copy link
Collaborator

@dbast dbast commented Dec 27, 2023

Also exclude .md files from trailing-whitespace hook and update hooks via pre-commit autoupdate.

closes #7

michalfita
michalfita approved these changes Dec 27, 2023
View reviewed changes
Copy link
Owner

@michalfita michalfita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have doubts about details of results, but in principle this is correct approach.

README.md Outdated Show resolved Hide resolved
@dbast dbast marked this pull request as draft December 27, 2023 15:17
@michalfita michalfita mentioned this pull request Dec 27, 2023
Closed
@dbast
pre-commit: handle *.md files with mdformat + apply it
40879e6 
Also exclude .md files from trailing-whitespace hook and update hooks via
`pre-commit autoupdate`.
@dbast dbast marked this pull request as ready for review December 30, 2023 08:58
@dbast
Copy link
Collaborator Author

dbast commented Dec 30, 2023 •
edited
Loading

@michalfita This is now ready again, as the !\[NOTE\] syntax issue could be fixed by using \[!NOTE\], which avoids the mdformat issue. I guess hukkin/mdformat-gfm#29 can be also closed.

@dbast dbast merged commit a42d6e2 into development Dec 30, 2023
26 of 27 checks passed
@dbast dbast deleted the pre-commit branch December 30, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalfita michalfita michalfita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent pre-commit to remove trailing whitespaces from Markdown files
2 participants
@dbast @michalfita