-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
219 refactor workflow automation to use berkley metadata models #253
Merged
mbthornton-lbl
merged 57 commits into
252-workflow-automation-berkley-rc1
from
219-refactor-workflow_automation-to-use-berkley-metadata-models
Oct 1, 2024
Merged
219 refactor workflow automation to use berkley metadata models #253
mbthornton-lbl
merged 57 commits into
252-workflow-automation-berkley-rc1
from
219-refactor-workflow_automation-to-use-berkley-metadata-models
Oct 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…medata/nmdc_automation into update-berkeley-configs
…ation-to-use-berkley-style-api-endpoints update workflow endpoint from activities to workflow_executions
…a-models' into update-berkeley-configs
Update berkeley configs
aclum
reviewed
Sep 27, 2024
aclum
reviewed
Sep 27, 2024
aclum
reviewed
Sep 27, 2024
aclum
reviewed
Sep 27, 2024
aclum
reviewed
Sep 27, 2024
aclum
reviewed
Sep 27, 2024
aclum
requested changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See individual comments.
aclum
reviewed
Sep 30, 2024
…rocess.git_url set
aclum
reviewed
Sep 30, 2024
aclum
approved these changes
Oct 1, 2024
mbthornton-lbl
changed the base branch from
main
to
252-workflow-automation-berkley-rc1
October 1, 2024 16:37
mbthornton-lbl
merged commit Oct 1, 2024
eb7b5e0
into
252-workflow-automation-berkley-rc1
1 check passed
mbthornton-lbl
deleted the
219-refactor-workflow_automation-to-use-berkley-metadata-models
branch
October 1, 2024 17:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides updates to the
workflow_automation
framework to be compatible with Berkley metadata models and runtime endpoints.This PR merges in these workflow configuration changes from:
This PR provides:
Update
activities.py
to be compatible with Berkley metadata:Changes
activities.py
toworkflow_process.py
load_activities
->load_workflow_process_nodes
Changes:
models.WorkflowProcessNode
process
attribute holds NMDCPlannedProcess
object.DataGeneration
andWorkflowExecution
are subtypes.models.py
and addedtest_models.py
Update endpoint use
Changes:
Refactor Watcher Class
Watcher
->Watcher
,FileHandler
,JobManager
,RuntimeApiHandler