Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

219 refactor workflow automation to use berkley metadata models #253

Conversation

mbthornton-lbl
Copy link
Contributor

@mbthornton-lbl mbthornton-lbl commented Sep 26, 2024

This PR provides updates to the workflow_automation framework to be compatible with Berkley metadata models and runtime endpoints.

This PR merges in these workflow configuration changes from:

  1. Update berkeley configs #237

This PR provides:

Update activities.py to be compatible with Berkley metadata:

  • update nmdc_automation/workflow_automation/activities.py for berkeley schema  #153
    Changes
  • refactored activities.py to workflow_process.py
  • refactored methods e.g. load_activities -> load_workflow_process_nodes
  • updated test fixtures to Berkley-compliant data
  • updated and added unit tests
  • Refactor Activity class #226
    Changes:
  • Activity class is refactored to models.WorkflowProcessNode
  • process attribute holds NMDC PlannedProcess object. DataGeneration and WorkflowExecution are subtypes.
  • data classes moved to models.py and added
  • added unit tests for object creation in test_models.py

Update endpoint use

Refactor Watcher Class
Watcher -> Watcher, FileHandler, JobManager, RuntimeApiHandler

aclum and others added 30 commits August 19, 2024 15:56
…ation-to-use-berkley-style-api-endpoints

update workflow endpoint from activities to workflow_executions
tests/import_test.yaml Outdated Show resolved Hide resolved
tests/workflows_test.yaml Outdated Show resolved Hide resolved
tests/workflows_test2.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@aclum aclum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See individual comments.

@mbthornton-lbl mbthornton-lbl marked this pull request as ready for review September 30, 2024 22:17
@mbthornton-lbl mbthornton-lbl changed the base branch from main to 252-workflow-automation-berkley-rc1 October 1, 2024 16:37
@mbthornton-lbl mbthornton-lbl merged commit eb7b5e0 into 252-workflow-automation-berkley-rc1 Oct 1, 2024
1 check passed
@mbthornton-lbl mbthornton-lbl deleted the 219-refactor-workflow_automation-to-use-berkley-metadata-models branch October 1, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants