Add JGI metagenomics long read class to submission schema #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…submission-schema
turbomam
reviewed
Mar 4, 2024
There was a problem hiding this comment.
do you know if we require the descriptions in the schemasheets classes.tsv file to be in a particular format? It looks like I set a pretty un-helpful precedent. Maybe we should start with descriptions that are more meaningful to humans in this PR. I could update the other ones later this week.
|
I don't think anything downstream relies on any particular description format, so yeah they should be more descriptive. See also: #186. I'll add something better for the classes added here. |
|
@turbomam Descriptions updated. Any other feedback? |
turbomam
approved these changes
Mar 5, 2024
pkalita-lbl
deleted the
168-add-jgi-metagenomics-long-read-class-to-submission-schema
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
JgiMgLrInterfaceclass. It is largely similar to the existingJgiMgInterfaceclass, but it represents metadata for samples to go for long-read sequencing. A few slots have different required/recommended values inJgiMgLrInterfaceas compared toJgiMgInterface.AnalysisTypeEnumis removed. It's not needed here since it is imported fromnmdc-schema.nmdc-schemadependency is bumped up to v10.1.0.