Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create examples/output/ again #204

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Conversation

turbomam
Copy link
Member

@turbomam turbomam commented Jul 3, 2024

targets that put stuff in examples/output/ may need to create the dir unless we change the cleanup mechanism

the absence of this dir creation step didn't seem to effect the GH Actions but it was leading to make squeaky-clean all test errors on my workstation

@turbomam turbomam requested a review from pkalita-lbl July 3, 2024 21:24
Copy link
Collaborator

@pkalita-lbl pkalita-lbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the reason you hit this locally but it doesn't affect any GitHub Actions workflows is that they all use clean and not squeaky-clean. Which begs the question why two? I mean, I can see that they do different things. But why? Regardless, that's a question for another day and this seems fine for now.

@pkalita-lbl pkalita-lbl merged commit e893661 into main Jul 3, 2024
2 checks passed
@pkalita-lbl pkalita-lbl deleted the create-example_output-again branch July 3, 2024 21:57
@turbomam
Copy link
Member Author

turbomam commented Jul 8, 2024

I started adding squeaky-clean targets to my LinkML Makefiles when I was green and didn't want to stray too far from the established clean actions. I agree, its confusing and should be unified or documented better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants