Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to nmdc-schema v11.0.1 #228

Merged
merged 5 commits into from
Oct 8, 2024
Merged

Upgrade to nmdc-schema v11.0.1 #228

merged 5 commits into from
Oct 8, 2024

Conversation

pkalita-lbl
Copy link
Collaborator

Despite the branch name, these changes build the submission-schema off of nmdc-schema v11.0.1.

Changes outside the normal upgrade process:

  • Because the post-Berkeley nmdc-schema uses alias_contexts on StructuredAlias instances, this project needed a more recent version of linkml to load nmdc-schema v11.x.x. These changes make the linkml dependency the same as it is in the nmdc-schema project.
  • With the linkml upgrade, oaklib and schemasheets also needed to be upgraded to make all of the transitive dependencies compatible.
  • gen-pop-linkml2sheets also became incompatible. That project has been archived. With no updates forthcoming, I just removed it as a dependency from this project. I believe it had beed added for some exploratory work; it's not part of the actual build process.
  • sheets-and-friends needed to be upgraded to deal with the downstream consequences of minimum_value and maximum_value possibly not being numeric anymore in the latest metamodel.
  • The new nmdc-schema has a lot of new inlined and inlined_as_list attributes (which it should!), but submission-schema overrides the multivalued attribute on most of those slots. So I've added yq commands (not my favorite, but it's SOP for now) to remove those from multivalued: false slot definitions.

Copy link

@eecavanna eecavanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with the submission schema. Given the PR description (thank you!), nothing in the diff looks problematic or unintentional to me, and I see that references to nmdc-schema version (Git tag) v10.8.0 have been replaced with references to version (Git tag) v11.0.1

@pkalita-lbl pkalita-lbl merged commit 9894d00 into main Oct 8, 2024
2 checks passed
@pkalita-lbl pkalita-lbl deleted the nmdc-schema-11.0.0 branch October 8, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants