WIP: [ci] [R-package] add a CI job to run R reverse dependency checks #6734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #6714
This proposes adding an optional CI job that runs a development build of the R package against all of the packages on CRAN that depend on it.
Hoping that this + manually searching https://github.com/cran will help us understand whether user-facing breaking changes will break other packages on CRAN.
Notes for Reviewers
Just opening this to test. Will fill out a better. description before putting it up for review.
ref: r-lib/actions#332 (comment)
Why not run this on PRs?
It's slow and expensive (it downloads and installs 130+ R packages). In my experience, more than half of PRs here do not even touch C++ or R code, and so shouldn't impact the result of this check.
This task of checking reverse dependencies is so expensive that at least as of 2021, Posit (formerly RStudio) was running a dedicated internal service just to do that (r-lib/actions#332 (comment)).
It's not TOO bad right now given the small number of packages on CRAN that depend on
{lightgbm}... if that even gets much larger and makes this too expensive to run in CI, that'll be a good problem to have 😊