Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[inetstack] Remove some dead code #1463

Merged
merged 1 commit into from
Nov 22, 2024
Merged

[inetstack] Remove some dead code #1463

merged 1 commit into from
Nov 22, 2024
+11 −35

Conversation

iyzhang
Copy link
Contributor

@iyzhang iyzhang commented Nov 15, 2024

We do not use the dead_socket transmission channel any more, so this PR removes it.

@iyzhang iyzhang self-assigned this Nov 15, 2024
@github-actions GitHub Actions
Copy link

libos = catpowder
commit id = f96960d

collapsed_stack num_calls cycles_per_call nanoseconds_per_call percent_time
bgc::inetstack::poll_recv;inetstack::layer4_endpoint::poll_once 18930099.80 705.92 309.77 85.41
bgc::inetstack::poll_recv 9465049.90 1660.20 728.62 53.46
bgc::inetstack::tcp::established::background 11053.09 1663.88 733.36 0.20
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 11053.09 480.69 215.03 21.78
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 11044.43 383.71 168.17 29.27
bgc::inetstack::tcp::established::background;tcp::established::background::sender 11002.55 936.92 411.34 24.96
ioc::network::libos::pop 9033.51 469.11 203.04 0.05
ioc::network::libos::push;inetstack::push 8762.80 6245.08 2739.76 2.41
demikernel::sgafree 8755.36 107.75 48.02 0.02
ioc::network::libos::push 8073.74 33476573.68 15432352.83 40.26
demikernel::push 8073.74 666.32 289.32 0.07
demikernel::sgaalloc 6511.38 171.81 74.96 0.03
demikernel::pop 6038.33 677.93 293.87 0.04
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for 5281.58 2545.69 1106.61 1.46
ioc::network::libos::pushto 799.33 4450.37 1939.92 3.53
ioc::network::libos::pushto;inetstack::push 799.33 4022.45 1753.41 90.39
demikernel::pushto 799.33 479.57 209.23 0.37
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for;udp::receive 264.67 191.98 86.56 59.90
ioc::network::libos::close 47.77 6271.85 2759.52 0.10
ioc::network::libos::connect 41.86 34572.72 15358.38 0.43
bgc::inetstack::tcp::passiveopen::background 41.86 34404.99 15152.14 0.01
ioc::network::libos::accept 38.29 2196.97 966.92 0.00
demikernel::async_close 32.50 698.58 303.13 0.01
demikernel::accept 21.86 1327.41 580.05 0.00
demikernel::connect 20.93 3868.65 1701.37 0.02
demikernel::socket 10.30 1635.87 716.40 0.00
bgc::inetstack::arp::background 6.38 1975.16 864.56 0.00
bgc::inetstack::poll_recv;inetstack::poll;inetstack::layer4_endpoint::poll_once 2.00 5773.02 2533.12 83.49
bgc::inetstack::icmp::background 1.03 3141.85 1377.80 0.00
demikernel::new 1.00 94219277.32 41332986.81 20.19
demikernel::bind 1.00 26771.75 11603.12 0.00
bgc::inetstack::poll_recv;inetstack::poll 1.00 13752.40 6033.85 0.04
demikernel::listen 1.00 3945.43 1685.35 0.00
demikernel::close 0.00 nan nan 0.00

@github-actions GitHub Actions
Copy link

libos = catnap
commit id = f96960d

collapsed_stack num_calls cycles_per_call nanoseconds_per_call percent_time
bgc::catnap::transport::epoll 13365246.75 2009.81 870.82 33.14
demikernel::sgafree 11534.88 71.06 30.15 0.05
demikernel::sgaalloc 11282.08 120.76 51.25 0.11
ioc::network::libos::push;catnap::linux::transport::push 9066.12 620.32 268.39 3.95
ioc::network::libos::push 8800.49 16495.26 7141.26 6.96
demikernel::push 8800.49 536.06 230.48 0.17
ioc::network::libos::pop;catnap::linux::transport::pop 8022.25 381.31 163.53 3.76
ioc::network::libos::pop 7813.82 21883485.65 9246334.75 24.28
demikernel::pop 7813.82 541.15 230.24 0.13
ioc::network::libos::pushto 560.67 7461.16 3333.88 23.35
ioc::network::libos::pushto;catnap::linux::transport::push 560.67 487.16 216.95 6.52
demikernel::pushto 560.67 453.95 202.75 1.43
demikernel::async_close 32.50 917.98 366.32 0.01
ioc::network::libos::connect 24.95 5509923.29 2315021.68 28.23
ioc::network::libos::connect;catnap::linux::transport::connect 24.95 76459.72 32141.55 2.29
demikernel::connect 24.95 2019.43 855.87 0.01
ioc::network::libos::close 18.35 23211.25 9922.74 0.05
ioc::network::libos::close;catnap::linux::transport::close 18.35 22132.63 9458.64 95.41
demikernel::accept 15.42 1450.99 628.30 0.00
ioc::network::libos::accept 15.39 896975501.16 393157358.86 44.42
ioc::network::libos::accept;catnap::linux::transport::accept 15.39 4591.96 1963.21 0.00
demikernel::socket 9.50 152961.45 65718.26 0.30
demikernel::socket;catnap::linux::transport::socket 9.50 150419.08 64628.55 96.33
demikernel::new 1.00 262261.60 111818.68 0.09
demikernel::bind 1.00 31697.65 13641.31 0.01
demikernel::bind;catnap::linux::transport::bind 1.00 27121.98 11669.86 84.70
demikernel::listen 1.00 15746.08 6766.69 0.00
demikernel::listen;catnap::linux::transport::listen 1.00 14621.37 6284.27 92.78
demikernel::close 0.00 nan nan 0.00

@github-actions GitHub Actions
Copy link

libos = catnip
commit id = f96960d

collapsed_stack num_calls cycles_per_call nanoseconds_per_call percent_time
bgc::inetstack::poll_recv;inetstack::layer4_endpoint::poll_once 29276553.17 338.31 146.33 75.71
bgc::inetstack::poll_recv;inetstack::layer4_endpoint::poll_once;catnip::runtime::receive 29276553.17 196.53 84.95 58.20
bgc::inetstack::poll_recv 14638276.58 900.07 389.83 34.81
bgc::inetstack::tcp::established::background 11055.12 1064.92 454.12 0.11
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 11055.12 294.78 125.39 25.32
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 11044.75 332.48 143.90 31.73
bgc::inetstack::tcp::established::background;tcp::established::background::sender 11002.75 301.99 121.65 15.30
ioc::network::libos::pop 9038.69 369.90 159.92 0.02
demikernel::sgafree 8764.66 78.77 34.08 0.01
ioc::network::libos::push;inetstack::push 8762.74 1953.83 877.94 0.68
ioc::network::libos::push;inetstack::push;catnip::runtime::transmit 8762.74 304.18 136.27 15.34
ioc::network::libos::push 8073.71 33400734.17 13673948.20 26.02
demikernel::push 8073.71 657.25 288.51 0.04
demikernel::sgaalloc 6518.33 128.15 55.17 0.01
demikernel::pop 6044.86 534.23 229.27 0.02
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for 4584.86 2390.62 978.43 2.03
ioc::network::libos::pushto 964.00 1325.19 591.92 0.04
ioc::network::libos::pushto;inetstack::push 964.00 718.50 320.91 54.46
demikernel::pushto 964.00 507.28 226.01 0.02
ioc::network::libos::pushto;inetstack::push;catnip::runtime::transmit 964.00 270.20 120.46 37.50
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for;udp::receive 406.33 246.87 107.73 70.57
ioc::network::libos::close 49.38 5879.72 2547.78 0.01
bgc::inetstack::tcp::passiveopen::background 41.86 34772.72 15524.70 0.00
ioc::network::libos::connect 41.86 31043.74 13556.46 0.04
ioc::network::libos::connect;catnip::runtime::transmit 41.86 6579.00 2916.74 22.45
ioc::network::libos::accept 37.96 2275.68 995.65 0.00
demikernel::async_close 32.50 585.33 233.69 0.00
demikernel::accept 21.86 1341.78 588.00 0.00
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for;catnip::runtime::transmit 21.09 628.20 273.07 3.41
bgc::inetstack::tcp::passiveopen::background;catnip::runtime::transmit 20.93 18060.53 8079.02 17.62
demikernel::connect 20.93 2608.92 1154.35 0.00
bgc::inetstack::tcp::established::background;tcp::established::background::sender;catnip::runtime::transmit 20.93 592.98 256.69 11.98
demikernel::socket 10.30 1649.91 718.58 0.00
bgc::inetstack::arp::background 6.43 2215.85 953.61 0.00
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger;catnip::runtime::transmit 5.00 1820.56 743.84 19.42
bgc::inetstack::poll_recv;inetstack::poll;inetstack::layer4_endpoint::poll_once 2.00 20073.17 8673.86 95.26
bgc::inetstack::poll_recv;inetstack::poll;inetstack::layer4_endpoint::poll_once;catnip::runtime::receive 2.00 17952.03 7754.43 89.42
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter;catnip::runtime::transmit 1.50 311.50 146.88 0.00
bgc::inetstack::icmp::background 1.05 2929.63 1263.98 0.00
demikernel::new 1.00 1763421093.20 761483738.66 48.50
bgc::inetstack::poll_recv;inetstack::poll 1.00 42133.37 18202.59 0.19
demikernel::bind 1.00 11371.12 4882.32 0.00
demikernel::listen 1.00 4423.79 1890.60 0.00
demikernel::close 0.00 nan nan 0.00

@iyzhang iyzhang force-pushed the enhancement-inetstack-remove-dead branch from f96960d to 043aa27 Compare November 20, 2024 22:57
@github-actions GitHub Actions
Copy link

libos = catpowder
commit id = 043aa27

collapsed_stack num_calls cycles_per_call nanoseconds_per_call percent_time
bgc::inetstack::poll_recv;inetstack::layer4_endpoint::poll_once 19306726.83 699.58 300.85 85.51
bgc::inetstack::poll_recv 9653363.42 1644.18 706.96 53.51
bgc::inetstack::tcp::established::background 11152.25 1654.69 718.09 0.19
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 11152.25 491.19 215.97 22.28
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 11143.62 379.25 164.68 28.88
bgc::inetstack::tcp::established::background;tcp::established::background::sender 11101.77 936.52 399.83 25.42
ioc::network::libos::pop 9054.69 415.64 178.40 0.04
ioc::network::libos::push;inetstack::push 8762.80 5974.94 2668.50 2.27
demikernel::sgafree 8751.08 104.51 44.90 0.01
ioc::network::libos::push 8073.74 33499906.55 19665376.21 40.23
demikernel::push 8073.74 602.35 266.42 0.06
demikernel::sgaalloc 6503.75 162.72 72.58 0.02
demikernel::pop 6037.49 595.14 255.49 0.04
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for 5375.03 2396.05 1035.70 1.40
ioc::network::libos::pushto 723.67 4547.31 1866.85 3.02
ioc::network::libos::pushto;inetstack::push 723.67 4122.65 1692.56 90.66
demikernel::pushto 723.67 491.13 201.61 0.33
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for;udp::receive 260.67 223.98 93.26 60.38
ioc::network::libos::close 47.72 6216.83 2708.76 0.08
ioc::network::libos::connect 41.86 48328.43 20630.71 0.37
bgc::inetstack::tcp::passiveopen::background 41.86 33892.66 14542.43 0.01
ioc::network::libos::accept 38.25 2115.39 908.34 0.00
demikernel::async_close 32.50 679.29 290.20 0.01
demikernel::accept 21.86 1208.66 518.51 0.00
demikernel::connect 20.93 4014.31 1789.58 0.02
demikernel::socket 10.30 2620.79 1130.53 0.00
bgc::inetstack::arp::background 6.38 1972.32 850.22 0.00
bgc::inetstack::poll_recv;inetstack::poll;inetstack::layer4_endpoint::poll_once 2.00 5469.47 2351.24 81.84
bgc::inetstack::icmp::background 1.03 3431.90 1474.12 0.00
demikernel::new 1.00 94278999.87 40623081.84 20.26
demikernel::bind 1.00 24217.62 10377.70 0.00
bgc::inetstack::poll_recv;inetstack::poll 1.00 13248.10 5698.03 0.04
demikernel::listen 1.00 2973.71 1271.98 0.00
demikernel::close 0.00 nan nan 0.00

@github-actions GitHub Actions
Copy link

libos = catnap
commit id = 043aa27

collapsed_stack num_calls cycles_per_call nanoseconds_per_call percent_time
bgc::catnap::transport::epoll 13381660.49 1902.61 860.88 32.98
demikernel::sgafree 11572.35 71.47 30.46 0.05
demikernel::sgaalloc 11358.55 117.73 51.73 0.11
ioc::network::libos::push;catnap::linux::transport::push 9066.08 707.00 309.82 4.25
ioc::network::libos::push 8800.47 16998.97 7491.04 6.55
demikernel::push 8800.47 532.95 232.39 0.15
ioc::network::libos::pop;catnap::linux::transport::pop 8034.69 399.93 171.71 3.37
ioc::network::libos::pop 7825.93 5191991.85 2170698.86 25.15
demikernel::pop 7825.93 562.42 240.15 0.11
ioc::network::libos::pushto 2022.67 7759.36 3201.96 24.05
ioc::network::libos::pushto;catnap::linux::transport::push 2022.67 481.83 198.79 6.31
demikernel::pushto 2022.67 423.78 174.95 1.50
demikernel::async_close 32.50 941.79 372.49 0.01
ioc::network::libos::connect 24.95 5479052.68 2385408.81 26.61
ioc::network::libos::connect;catnap::linux::transport::connect 24.95 76187.31 33265.60 2.49
demikernel::connect 24.95 1929.95 847.65 0.01
ioc::network::libos::close 18.35 24354.12 10511.49 0.05
ioc::network::libos::close;catnap::linux::transport::close 18.35 23134.63 9984.71 95.09
demikernel::accept 15.42 1567.08 678.93 0.00
ioc::network::libos::accept 15.39 903264771.30 393736279.27 44.90
ioc::network::libos::accept;catnap::linux::transport::accept 15.39 5820.15 2607.98 0.00
demikernel::socket 9.50 155994.84 67938.40 0.25
demikernel::socket;catnap::linux::transport::socket 9.50 153703.33 66948.37 96.57
demikernel::new 1.00 263886.12 114469.14 0.10
demikernel::bind 1.00 29358.22 12619.88 0.00
demikernel::bind;catnap::linux::transport::bind 1.00 24764.85 10644.14 84.01
demikernel::listen 1.00 14604.89 6280.04 0.00
demikernel::listen;catnap::linux::transport::listen 1.00 13520.95 5813.71 92.45
demikernel::close 0.00 nan nan 0.00

@github-actions GitHub Actions
Copy link

libos = catnip
commit id = 043aa27

collapsed_stack num_calls cycles_per_call nanoseconds_per_call percent_time
bgc::inetstack::poll_recv;inetstack::layer4_endpoint::poll_once 29315774.70 339.75 147.48 75.57
bgc::inetstack::poll_recv;inetstack::layer4_endpoint::poll_once;catnip::runtime::receive 29315774.70 197.82 85.78 58.32
bgc::inetstack::poll_recv 14657887.35 905.00 393.49 34.65
bgc::inetstack::tcp::established::background 11244.80 1074.87 461.41 0.11
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger 11244.80 312.96 134.10 26.07
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter 11234.48 336.32 146.45 31.97
bgc::inetstack::tcp::established::background;tcp::established::background::sender 11192.38 297.68 120.88 15.50
ioc::network::libos::pop 9144.20 372.12 162.77 0.02
demikernel::sgafree 8776.91 79.13 34.48 0.01
ioc::network::libos::push;inetstack::push 8762.80 2066.60 928.21 0.70
ioc::network::libos::push;inetstack::push;catnip::runtime::transmit 8762.80 358.69 159.98 16.13
ioc::network::libos::push 8073.74 33406916.49 13865447.88 25.73
demikernel::push 8073.74 688.95 302.93 0.04
demikernel::sgaalloc 6531.83 145.93 63.32 0.01
demikernel::pop 6051.24 530.60 230.63 0.02
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for 4681.63 2121.12 879.66 2.08
ioc::network::libos::pushto 1180.00 1353.78 584.43 0.05
ioc::network::libos::pushto;inetstack::push 1180.00 741.27 319.80 55.04
demikernel::pushto 1180.00 487.64 210.23 0.02
ioc::network::libos::pushto;inetstack::push;catnip::runtime::transmit 1180.00 268.36 115.88 36.15
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for;udp::receive 526.33 239.89 106.69 71.07
bgc::inetstack::poll_recv;inetstack::poll_bg_work::for::for;catnip::runtime::transmit 209.46 660.21 287.38 3.45
ioc::network::libos::close 49.45 6094.29 2667.51 0.01
ioc::network::libos::connect 41.86 35545.02 15944.30 0.04
bgc::inetstack::tcp::passiveopen::background 41.86 35518.72 15605.43 0.00
ioc::network::libos::connect;catnip::runtime::transmit 41.86 6582.87 2972.90 20.25
ioc::network::libos::accept 38.25 2227.49 967.36 0.00
demikernel::async_close 32.50 575.84 228.17 0.00
demikernel::accept 21.86 1370.32 595.99 0.00
bgc::inetstack::tcp::passiveopen::background;catnip::runtime::transmit 20.93 19225.56 8478.48 18.86
demikernel::connect 20.93 2768.29 1241.04 0.00
bgc::inetstack::tcp::established::background;tcp::established::background::sender;catnip::runtime::transmit 20.93 672.11 293.75 11.57
bgc::inetstack::tcp::established::background;tcp::established::background::retransmitter;catnip::runtime::transmit 10.67 342.98 160.00 0.01
demikernel::socket 10.30 2623.40 1146.80 0.00
bgc::inetstack::arp::background 6.43 2255.67 973.46 0.00
bgc::inetstack::tcp::established::background;tcp::established::background::acknowledger;catnip::runtime::transmit 5.00 2422.89 997.98 21.26
bgc::inetstack::poll_recv;inetstack::poll;inetstack::layer4_endpoint::poll_once 2.00 21275.30 9284.96 95.72
bgc::inetstack::poll_recv;inetstack::poll;inetstack::layer4_endpoint::poll_once;catnip::runtime::receive 2.00 19034.28 8313.31 89.13
bgc::inetstack::icmp::background 1.05 2984.22 1293.94 0.00
demikernel::new 1.00 1754070466.70 759843926.52 48.83
bgc::inetstack::poll_recv;inetstack::poll 1.00 44401.03 19372.15 0.16
demikernel::bind 1.00 9804.69 4217.47 0.00
demikernel::listen 1.00 3725.50 1588.47 0.00
demikernel::close 0.00 nan nan 0.00

anandbonde
anandbonde approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@anandbonde anandbonde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@anandbonde anandbonde merged commit 38b7fdf into dev Nov 22, 2024
14 checks passed
@anandbonde anandbonde deleted the enhancement-inetstack-remove-dead branch November 22, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandbonde anandbonde anandbonde approved these changes

Assignees

@iyzhang iyzhang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iyzhang @anandbonde