-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[File Explorer Source Control Integration] Accessibility bug fixes #3906
Conversation
@@ -40,15 +40,20 @@ | |||
Orientation="Horizontal"> | |||
<DropDownButton | |||
Content="{Binding SourceControlProviderDisplayName}" | |||
ToolTipService.ToolTip="{Binding SourceControlProviderPackageDisplayName}"> | |||
AutomationProperties.Name="{Binding RepoPathMapping}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this set the name correctly (does it sound right in Narrator / look right in acc insights/inspect) or don't you need to do the
<data name="ButtonName.[using:Microsoft.UI.Xaml.Automation]AutomationProperties.Name" xml:space="preserve">
thing in the resw file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it does seem to set the name correctly. In narrator, the path is correctly announced with backslashes, followed by the status of the drop down button. I also checked with Accessibility Insights and it did not flag any issues. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting a binding for the automation name is needed when something has to change between all the items. For example, in RepoConfig. The narrator says for the edit button "Edit repository [path]" where path is different for each item.
Summary of the pull request
This PR fixes two accessibility bugs for the File Explorer Page under Windows Customization.
References and relevant issues
https://microsoft.visualstudio.com/OS/_workitems/edit/53874018
https://microsoft.visualstudio.com/OS/_workitems/edit/53873865
Detailed description of the pull request / Additional comments
The accessibility bugs that this PR resolves are:
Validation steps performed
Used narrator to confirm that the following expected results were achieved:
PR checklist