Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Quickstart Playground Experimental Feature #3961

Merged
merged 1 commit into from
Oct 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions common/Contracts/IQuickstartSetupService.cs

This file was deleted.

12 changes: 0 additions & 12 deletions common/Models/ExperimentalFeature.cs
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@ public partial class ExperimentalFeature : ObservableObject

public static ILocalSettingsService? LocalSettingsService { get; set; }

public static IQuickstartSetupService? QuickstartSetupService { get; set; }

public ExperimentalFeature(string id, bool enabledByDefault, bool needsFeaturePresenceCheck, string openPageKey, string openPageParameter, bool visible = true)
{
Id = id;
Expand Down Expand Up @@ -85,16 +83,6 @@ public async Task OnToggledAsync()
await LocalSettingsService!.SaveSettingAsync($"IsSeeker", true);

TelemetryFactory.Get<ITelemetry>().Log("ExperimentalFeature_Toggled_Event", LogLevel.Critical, new ExperimentalFeatureEvent(Id, IsEnabled));

// To simplify setup for the Quickstart experimental feature, install the associated Dev Home Azure Extension if it's not already present
// when that feature is enabled. Those operations will only occur on Canary and Stable builds of Dev Home.
if (string.Equals(Id, "QuickstartPlayground", StringComparison.Ordinal) && IsEnabled)
{
if (!QuickstartSetupService!.IsDevHomeAzureExtensionInstalled())
{
await QuickstartSetupService!.InstallDevHomeAzureExtensionAsync();
}
}
}

[RelayCommand]
Expand Down
53 changes: 0 additions & 53 deletions common/Services/QuickstartSetupService.cs

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

8 changes: 0 additions & 8 deletions settings/DevHome.Settings/Strings/en-us/Resources.resw
Original file line number Diff line number Diff line change
Expand Up @@ -553,14 +553,6 @@
<value>Quiet background processes allows you to free up resources while developing</value>
<comment>Inline description of the Quiet background processes experimental feature on the 'Settings -&gt; Experiments' page where you enable it.</comment>
</data>
<data name="QuickstartPlayground_Name" xml:space="preserve">
<value>Quickstart Playground</value>
<comment>Locked="{Quickstart Playground}" Title text for the Quickstart Playground feature.</comment>
</data>
<data name="QuickstartPlayground_Description" xml:space="preserve">
<value>Get started in a new devcontainer-based project from a natural language prompt. Enabling this feature installs the Dev Home Azure Extension from the Store.</value>
<comment>Text within a display card that explains what users can do with the Quickstart Playground feature. Users can choose to toggle this feature on or off.</comment>
</data>
<data name="FileExplorerSourceControlIntegration_Name" xml:space="preserve">
<value>File Explorer Source Control Integration</value>
<comment>Name of experimental feature 'FileExplorer SourceControl Integration' on the 'Settings -&gt; Experiments' page where you enable it.</comment>
Expand Down
1 change: 0 additions & 1 deletion src/App.xaml.cs
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,6 @@ public App()
services.AddSingleton<IScreenReaderService, ScreenReaderService>();
services.AddSingleton<IComputeSystemService, ComputeSystemService>();
services.AddSingleton<IComputeSystemManager, ComputeSystemManager>();
services.AddSingleton<IQuickstartSetupService, QuickstartSetupService>();
services.AddTransient<AdaptiveCardRenderingService>();

// Core Services
Expand Down
1 change: 0 additions & 1 deletion src/Models/ExtensionWrapper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ public class ExtensionWrapper : IExtensionWrapper
[typeof(ISettingsProvider)] = ProviderType.Settings,
[typeof(IFeaturedApplicationsProvider)] = ProviderType.FeaturedApplications,
[typeof(IComputeSystemProvider)] = ProviderType.ComputeSystem,
[typeof(IQuickStartProjectProvider)] = ProviderType.QuickStartProject,
[typeof(ILocalRepositoryProvider)] = ProviderType.LocalRepository,
};

Expand Down
25 changes: 0 additions & 25 deletions src/NavConfig.jsonc
Original file line number Diff line number Diff line change
Expand Up @@ -106,31 +106,6 @@
"parameter": "ShowFileExplorer"
}
},
{
"identity": "QuickstartPlayground",
"enabledByDefault": false,
"buildTypeOverrides": [
{
"buildType": "dev",
"enabledByDefault": true,
"visible": true
},
{
"buildType": "canary",
"enabledByDefault": false,
"visible": true
},
{
"buildType": "stable",
"enabledByDefault": false,
"visible": true
}
],
"openPage": {
"key": "DevHome.SetupFlow.ViewModels.SetupFlowViewModel",
"parameter": "StartQuickstartPlayground"
}
},
{
"identity": "RepositoryManagementExperiment",
"enabledByDefault": false,
Expand Down
3 changes: 1 addition & 2 deletions src/Services/PageService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public class PageService : IPageService

private readonly Dictionary<string, Type> _pages = new();

public PageService(ILocalSettingsService localSettingsService, IExperimentationService experimentationService, IQuickstartSetupService quickstartSetupService)
public PageService(ILocalSettingsService localSettingsService, IExperimentationService experimentationService)
{
// Configure top-level pages from registered tools
var assemblies = AppDomain.CurrentDomain.GetAssemblies();
Expand All @@ -51,7 +51,6 @@ where assembly.GetName().Name == tool.Assembly

// Configure Experimental Feature pages
ExperimentalFeature.LocalSettingsService = localSettingsService;
ExperimentalFeature.QuickstartSetupService = quickstartSetupService;
foreach (var experimentalFeature in App.NavConfig.ExperimentFeatures ?? Array.Empty<DevHome.Helpers.ExperimentalFeatures>())
{
var enabledByDefault = experimentalFeature.EnabledByDefault;
Expand Down

This file was deleted.

Binary file not shown.
11 changes: 0 additions & 11 deletions tools/SetupFlow/DevHome.SetupFlow/DevHome.SetupFlow.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,6 @@
<Page Update="Views\Summary\SummaryNeedsRestart.xaml">
<Generator>MSBuild:Compile</Generator>
</Page>
<Page Update="Styles\QuickstartStyles.xaml">
<Generator>MSBuild:Compile</Generator>
</Page>
<Page Update="Views\CloneRepoSummaryInformationView.xaml">
<Generator>MSBuild:Compile</Generator>
</Page>
Expand All @@ -82,9 +79,6 @@
<Page Update="Views\SetupTargetView.xaml">
<Generator>MSBuild:Compile</Generator>
</Page>
<Page Update="Views\QuickstartPlaygroundView.xaml">
<Generator>MSBuild:Compile</Generator>
</Page>
<Page Update="Styles\AppManagement_ThemeResources.xaml">
<XamlRuntime>$(DefaultXamlRuntime)</XamlRuntime>
<SubType>Designer</SubType>
Expand Down Expand Up @@ -117,7 +111,6 @@
<None Remove="SetupFlowPage.xaml" />
<None Remove="Controls\SetupShell.xaml" />
<None Remove="Styles\AppManagement_ThemeResources.xaml" />
<None Remove="Styles\QuickstartStyles.xaml" />
<None Remove="Styles\SetupFlowStyles.xaml" />
<None Remove="Styles\SetupFlow_ThemeResources.xaml" />
<None Remove="Views\AddRepoDialog.xaml" />
Expand All @@ -127,7 +120,6 @@
<None Remove="Views\EditClonePathDialog.xaml" />
<None Remove="Views\LoadingView.xaml" />
<None Remove="Views\MainPageView.xaml" />
<None Remove="Views\QuickstartPlaygroundView.xaml" />
<None Remove="Views\RepoConfigReviewView.xaml" />
<None Remove="Views\RepoConfigView.xaml" />
<None Remove="Views\ReviewView.xaml" />
Expand Down Expand Up @@ -283,9 +275,6 @@
<Content Update="Assets\Setup_EndToEnd.png">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</Content>
<Content Update="Assets\Setup_QuickstartPlayground.png">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</Content>
<Content Update="Assets\Setup_RepoConfig.png">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</Content>
Expand Down
13 changes: 0 additions & 13 deletions tools/SetupFlow/DevHome.SetupFlow/Extensions/ServiceExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ public static IServiceCollection AddSetupFlow(this IServiceCollection services,
services.AddRepoConfig();
services.AddReview();
services.AddSummary();
services.AddQuickstart();
services.AddSummaryInformation();
services.AddCreateEnvironment();

Expand Down Expand Up @@ -166,18 +165,6 @@ private static IServiceCollection AddSetupTarget(this IServiceCollection service
return services;
}

private static IServiceCollection AddQuickstart(this IServiceCollection services)
{
// View models
services.AddTransient<QuickstartPlaygroundViewModel>();

// Services
services.AddTransient<DeveloperQuickstartTaskGroup>();
services.AddSingleton<IQuickStartProjectService, QuickStartProjectService>();

return services;
}

private static IServiceCollection AddCreateEnvironment(this IServiceCollection services)
{
// Task groups
Expand Down
Loading
Loading