This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
[WIP] Add join v2 rule #501
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sezruby
commented
Oct 12, 2021
| import com.microsoft.hyperspace.index.sources.FileBasedRelation | ||
| import com.microsoft.hyperspace.util.ResolverUtils.resolve | ||
|
|
||
| trait JoinQueryPlanIndexFilter extends QueryPlanIndexFilter { |
There was a problem hiding this comment.
All functions are copied from JoinIndexRule (private -> protected)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context for this pull request?
What changes were proposed in this pull request?
Add a new rule for join query.
Currently, Hyperspace applies indexes only if there are available indexes for both left and right plan. (and their indexed columns should be the same).
However, applying one index can also be beneficial when it can remove the shuffle for one of left and right child.
I created a separate rule instead of merging the existing JoinIndexRule, because
The rule is disabled by default and can enable by a spark config:
Does this PR introduce any user-facing change?
Yes
How was this patch tested?
Unit test
TODO: