Typescript - introducing index files namespace wise fixing circular dependency #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikithauc
requested review from
andrueastman,
baywet,
darrelmiller,
zengin,
MIchaelMainer,
ddyett,
peombwa and
ramsessanchez
as code owners
nikithauc
commented
Feb 28, 2022
baywet
requested changes
Feb 28, 2022
…iota into nikithauc/test-index
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
|
@nikithauc FYI I just merged main into this branch to solve conflicts with all recent changes. I didn't rebase in case you have local uncomitted or unpushed changes to avoid making your life more complicated. Just remember to pull next time you work on this. |
baywet
requested changes
Mar 17, 2022
src/Kiota.Builder/Writers/TypeScript/TypeScriptRelativeImportManager.cs
Outdated
Show resolved
Hide resolved
src/Kiota.Builder/Writers/TypeScript/TypeScriptRelativeImportManager.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
…iota into nikithauc/test-index
zengin
reviewed
Mar 18, 2022
tests/Kiota.Builder.Tests/Writers/TypeScript/CodeNamespaceWriterTests.cs
Outdated
Show resolved
Hide resolved
…erTests.cs Co-authored-by: Mustafa Zengin <muzengin@microsoft.com>
baywet
requested changes
Mar 18, 2022
baywet
previously approved these changes
Mar 18, 2022
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
baywet
previously approved these changes
Mar 18, 2022
baywet
requested changes
Mar 19, 2022
baywet
previously approved these changes
Mar 21, 2022
|
Kudos, SonarCloud Quality Gate passed! |
baywet
approved these changes
Mar 21, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #870.
Read more : https://medium.com/visual-development/how-to-fix-nasty-circular-dependency-issues-once-and-for-all-in-javascript-typescript-a04c987cf0de