Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- fixes #1270 a bug where missing schema title would make union types fail #1381

Merged
merged 4 commits into from
Mar 16, 2022
Merged

- fixes #1270 a bug where missing schema title would make union types fail #1381

merged 4 commits into from
Mar 16, 2022

Conversation

baywet
Copy link
Member

@baywet baywet commented Mar 14, 2022 •
edited
Loading

fixes #1270
fixes #1271

@baywet baywet added this to the Community Preview milestone Mar 14, 2022
@baywet baywet added the generator Issues or improvements relater to generation capabilities. label Mar 14, 2022
@baywet baywet self-assigned this Mar 14, 2022
@baywet baywet linked an issue Mar 14, 2022 that may be closed by this pull request
The GetSchemaTitles functions returns no options when no allOf, anyOf, oneOf children have titles. #1270
Closed
@baywet baywet force-pushed the bugfix/schema-title branch from 96ed54e to f2a03f4 Compare March 15, 2022 12:39
@baywet baywet mentioned this pull request Mar 15, 2022
Closed
@baywet baywet force-pushed the bugfix/schema-title branch from f2a03f4 to b5b4e19 Compare March 15, 2022 16:21
@baywet baywet marked this pull request as ready for review March 15, 2022 16:22
@baywet baywet enabled auto-merge March 15, 2022 16:22
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.3% 83.3% Coverage
0.0% 0.0% Duplication

@baywet baywet merged commit 5438548 into main Mar 16, 2022
@baywet baywet deleted the bugfix/schema-title branch March 16, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@zengin zengin Awaiting requested review from zengin

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@ddyett ddyett Awaiting requested review from ddyett

@peombwa peombwa Awaiting requested review from peombwa

@nikithauc nikithauc Awaiting requested review from nikithauc

@ramsessanchez ramsessanchez Awaiting requested review from ramsessanchez

Assignees

@baywet baywet

Labels
generator Issues or improvements relater to generation capabilities. WIP
Projects
None yet
Milestone
Community Preview
2 participants
@baywet @andrueastman