Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress errors in .ts files using ts-ignore #4398

Merged
merged 5 commits into from
Mar 26, 2024

Conversation

sher
Copy link
Contributor

@sher sher commented Mar 25, 2024

Fixes #4397

Added // @ts-ignore comment line as per discussion to suppress typecheck errors.

Currently, generated TypeScript .ts files contain imports that are never referenced in the code.
This causes TypeScript typecheck to fail in projects where tsconfig.json compiler option noUnusedLocals: true is set.
Example: Vitejs template tsconfig.json

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution.
Can you please:

  • add a changelog entry
  • update the corresponding unit test

Thanks!

@sher
Copy link
Contributor Author

sher commented Mar 25, 2024

@microsoft-github-policy-service agree company="Cybozu"

@sher sher requested a review from baywet March 25, 2024 23:01
@sher
Copy link
Contributor Author

sher commented Mar 26, 2024

  • updated unit test
  • updated CHANGELOG

@andrueastman andrueastman enabled auto-merge March 26, 2024 05:38
auto-merge was automatically disabled March 26, 2024 05:42

Pull Request is not mergeable

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!

@baywet baywet merged commit 84eca00 into microsoft:main Mar 26, 2024
199 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Unused type imports Parsable and ParsableFactory are causing build fail
3 participants