Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes failing Php integration tests because of wrong parameter types #5843

Merged
merged 32 commits into from
Dec 5, 2024
Merged

Fixes failing Php integration tests because of wrong parameter types #5843

merged 32 commits into from
Dec 5, 2024

Conversation

timayabi2020
Copy link
Contributor

Fixes #5779

Microsoft Graph DevX Tooling and others added 27 commits November 28, 2024 00:33
Updated discriminator method to ensure that primitive types don't def…
0fbb488 
…ault to collection of objects
Checked for null type definition
d9caaa9
Default to collection of primitive types for testing
b553e9e
More updates on code method writer
4dd6a01
Rolled back the default to object values
88c7ad2
Added back enum check
de7c924
Defaulted any null type definitions to collection of object values
35551a1
Rolled back
803e377
Ensured that parameter passed to getCollectionOfPrimitiveValues is a …
0f05da2 
…string
@timayabi2020
Merge branch 'main' into fix/php-integration-tests
aba8d81
Updted method write
a5fa774
Updated code method writer for php
17a56af
More experimental updates
122a646
Updated parseNodeMethod to be a collection of primitive values if typ…
55047ba 
…e definition is null
Defaulted parseNode method to a string incase type definition is null
d892c51
Fixed undefined property error
f7b2070
Updated method writer during null checks in typedefinition
e38b2b0
Updated code writer
32c2757
Updates
ea585a4
Rectified typo
a7cab36
More tests
3af85e6
@timayabi2020
Merge branch 'main' into fix/php-integration-tests
50de6be
Default to get String values
a11a427
Revert changes
994b96c
Added expected data type for setString method which takes a primitive…
6e0bcc6 
… function that returns an array of mixed types
Updated regex in phpstan.neon
07b21e0
@timayabi2020
Merge branch 'main' into fix/php-integration-tests
a4f4306
@timayabi2020 timayabi2020 marked this pull request as ready for review December 4, 2024 11:26
@timayabi2020 timayabi2020 requested a review from a team as a code owner December 4, 2024 11:26
@timayabi2020 timayabi2020 requested a review from baywet December 5, 2024 07:33
@timayabi2020 timayabi2020 merged commit eb93ca9 into main Dec 5, 2024
213 checks passed
@timayabi2020 timayabi2020 deleted the fix/php-integration-tests branch December 5, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Kiota
Status: Done ✔️
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Php integration failing due to wrong parameter types.
2 participants
@timayabi2020 @baywet